Skip to content

Pulling some additional fixes from 10310 for 2.8#10588

Merged
keveleigh merged 8 commits into
microsoft:prerelease/2.8.0from
keveleigh:system-type
May 16, 2022
Merged

Pulling some additional fixes from 10310 for 2.8#10588
keveleigh merged 8 commits into
microsoft:prerelease/2.8.0from
keveleigh:system-type

Conversation

@keveleigh

Copy link
Copy Markdown
Contributor

Overview

See #10310 for more context.

@keveleigh keveleigh added this to the MRTK 2.8 milestone May 16, 2022
@keveleigh keveleigh requested a review from RogPodge May 16, 2022 18:14
@keveleigh keveleigh requested a review from david-c-kline as a code owner May 16, 2022 18:14
@keveleigh keveleigh self-assigned this May 16, 2022
@keveleigh

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@david-c-kline david-c-kline left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of suggestions / questions

Comment thread Assets/MRTK/Core/Attributes/SystemTypeAttribute.cs
Comment thread Assets/MRTK/Core/Services/BaseEventSystem.cs Outdated
@keveleigh

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh keveleigh merged commit 741f9aa into microsoft:prerelease/2.8.0 May 16, 2022
@keveleigh keveleigh deleted the system-type branch May 16, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants