Fix for missing BC docs + dead property#10361
Merged
Merged
Conversation
Zee2
added
Documentation
Bug
UX Controls - Bounds Control
Zee2
requested review from
CDiaz-MS,
MaxWang-MS,
RogPodge,
david-c-kline and
keveleigh
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
reviewed
Dec 8, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
RogPodge
approved these changes
Dec 8, 2021
Contributor
|
This is definitely a nit, but I was just looking at the docs page linked in the issue and noticed there are some other public functions missing comments. Could you add |
keveleigh
approved these changes
Dec 9, 2021
Contributor
Author
|
/azp run |
Contributor
Author
|
@keveleigh @MaxWang-MS should be fixed. |
|
Azure Pipelines successfully started running 2 pipeline(s). |
MaxWang-MS
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As part of fixing some missing BC doccomments, I discovered that the public
BoundsCornersproperty was actually dead code and was never referenced by anything. This fixes the doccomments and removes this dead property.Changes
BoundsControl.BoundsCorners. This property was completely un-referenced and was never actually populated by any data.Verification
All BoundsControl tests pass.