Fixed objects drifting during Near Manipulation#10294
Merged
Merged
Conversation
RogPodge
requested review from
CDiaz-MS,
david-c-kline,
julenka and
keveleigh
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
reviewed
Nov 5, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
approved these changes
Nov 9, 2021
keveleigh
left a comment
keveleigh
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable to me! I didn't pull this down to test it, but the changes themselves seem good
Contributor
|
Nice job on the fix! |
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
* Fixed objects drifting during Near Manipulation * Updated unit tests, made near manipulation consistent to avoid weird offset behaviors * missing changes * reverted manipulation handler changes due to it being obsolete, fixed CI * removed debug
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
* Fixed objects drifting during Near Manipulation * Updated unit tests, made near manipulation consistent to avoid weird offset behaviors * missing changes * reverted manipulation handler changes due to it being obsolete, fixed CI * removed debug
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
* Fixed objects drifting during Near Manipulation * Updated unit tests, made near manipulation consistent to avoid weird offset behaviors * missing changes * reverted manipulation handler changes due to it being obsolete, fixed CI * removed debug
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
* Fixed objects drifting during Near Manipulation * Updated unit tests, made near manipulation consistent to avoid weird offset behaviors * missing changes * reverted manipulation handler changes due to it being obsolete, fixed CI * removed debug
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
* Fixed objects drifting during Near Manipulation * Updated unit tests, made near manipulation consistent to avoid weird offset behaviors * missing changes * reverted manipulation handler changes due to it being obsolete, fixed CI * removed debug
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 8, 2021
* Fixed objects drifting during Near Manipulation * Updated unit tests, made near manipulation consistent to avoid weird offset behaviors * missing changes * reverted manipulation handler changes due to it being obsolete, fixed CI * removed debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixed issue with the Object Manipulator causing objects to drift during near manipulationl
Changes