Skip to content

Add option to move grasp point to fingertip#10206

Merged
keveleigh merged 3 commits into
microsoft:mainfrom
jonathoncobb:jonathoncobb/fingertip-pointer
Oct 5, 2021
Merged

Add option to move grasp point to fingertip#10206
keveleigh merged 3 commits into
microsoft:mainfrom
jonathoncobb:jonathoncobb/fingertip-pointer

Conversation

@jonathoncobb

Copy link
Copy Markdown
Member

The grasp pointer by default is positioned between the thumb and index finger. However this is confusing if a fingertip cursor is rendered (either because one is added to the grasp pointer or because grabbable elements are near pokable ones). This adds an option to move the grasp point to the fingertip if desired.

Changes

  • Fixes: # .

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

The grasp pointer by default is positioned between the thumb and index finger. However this is confusing if a fingertip cursor is rendered (either because one is added to the grasp pointer or because grabbable elements are near pokable ones). This adds an option to move the grasp point to the fingertip if desired.
Comment thread Assets/MRTK/SDK/Features/UX/Scripts/Pointers/SpherePointer.cs Outdated
@RogPodge

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

Comment thread Assets/MRTK/SDK/Features/UX/Scripts/Pointers/SpherePointer.cs Outdated
Comment thread Assets/MRTK/SDK/Features/UX/Scripts/Pointers/SpherePointer.cs Outdated
@david-c-kline

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh keveleigh merged commit 83b9e57 into microsoft:main Oct 5, 2021
keveleigh added a commit that referenced this pull request Nov 19, 2021
@polar-kev polar-kev added this to the MRTK 2.7.3 milestone Nov 22, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…gertip-pointer

Add option to move grasp point to fingertip
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…gertip-pointer

Add option to move grasp point to fingertip
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…gertip-pointer

Add option to move grasp point to fingertip
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…gertip-pointer

Add option to move grasp point to fingertip
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…gertip-pointer

Add option to move grasp point to fingertip
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 8, 2021
…gertip-pointer

Add option to move grasp point to fingertip
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants