Skip to content

UnityTouchDeviceManager now respects its IsEnabled property#10203

Merged
keveleigh merged 1 commit into
microsoft:mainfrom
marek-stoj:patch-1
Sep 10, 2021
Merged

UnityTouchDeviceManager now respects its IsEnabled property#10203
keveleigh merged 1 commit into
microsoft:mainfrom
marek-stoj:patch-1

Conversation

@marek-stoj

Copy link
Copy Markdown
Contributor

Overview

UnityTouchDeviceManager, as other data providers (eg. XRSDKDeviceManager), should not Update itself if its IsEnabled property is false.

Changes

  • Fixes: # .

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@keveleigh

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh keveleigh merged commit 97c33c7 into microsoft:main Sep 10, 2021
@keveleigh

Copy link
Copy Markdown
Contributor

Thanks for the fix!

@polar-kev polar-kev added this to the MRTK 2.7.3 milestone Nov 22, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
UnityTouchDeviceManager now respects its IsEnabled property
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
UnityTouchDeviceManager now respects its IsEnabled property
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
UnityTouchDeviceManager now respects its IsEnabled property
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
UnityTouchDeviceManager now respects its IsEnabled property
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
UnityTouchDeviceManager now respects its IsEnabled property
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 8, 2021
UnityTouchDeviceManager now respects its IsEnabled property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants