Skip to content

Conversation

manodasanW
Copy link
Member

  • Fixing ObjectDisposedException thrown during exception propagation when the language exception in the error info is a non C# exception.
  • Added various test cases to test the various exception propagation scenarios

Putting this in draft as I plan to have another change to improve error propagation

Fixes #1845

@manodasanW manodasanW marked this pull request as ready for review November 3, 2024 02:08
@jamers99
Copy link

jamers99 commented Nov 4, 2024

Once this is in master, how soon will this be available in a nuget package?

@manodasanW
Copy link
Member Author

Once this is in master, how soon will this be available in a nuget package?

I am planning to do a Windows SDK projection update by next Monday which I plan on including this in. It would be a month from then before it is available by default in the .NET SDK, but you should be able to pick up that version I ship before then in your app explicitly by using the WindowsSdkPackageVersion property to specify the explicit version to use in your csproj or a common props file. If you let me know the OS version that your target in your target framework and what version of .NET that you target, I would be able to give you the exact version that you can specify when our updates go out.

@jamers99
Copy link

jamers99 commented Nov 7, 2024

@manodasanW sweet! We're looking forward to it. Here's our current .props:
image

We'd be able to target 19041 as our min if needed. Even our other targets are flexible if there are any issues.

@manodasanW manodasanW merged commit 3740e12 into master Nov 8, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/exceptionPropagation branch November 8, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ObjectDisposedException thrown during crash, corrupting crash report
3 participants