Add 'CsWinRTMergeReferencedActivationFactories' option #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
enhancement
Sergio0694
force-pushed
the
user/sergiopedri/merged-activation-factories
branch
from
9cc6d81 to
6ca3960
Compare
|
Seems to work fine when testing locally 🙂 Disabled (click to expand):
Enabled (click to expand):
|
nagya
reviewed
Jun 13, 2024
Sergio0694
force-pushed
the
user/sergiopedri/merged-activation-factories
branch
from
38fee78 to
9709e11
Compare
manodasanW
reviewed
Jun 27, 2024
src/Authoring/WinRT.SourceGenerator/MergeReferencedActivationFactoriesGenerator.cs
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Jun 27, 2024
src/Authoring/WinRT.SourceGenerator/MergeReferencedActivationFactoriesGenerator.cs
Outdated
Show resolved
Hide resolved
manodasanW
approved these changes
Jun 28, 2024
Sergio0694
force-pushed
the
user/sergiopedri/merged-activation-factories
branch
from
6fea3f1 to
1c735f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
[WinRTAssemblyExportsType]attributeCsWinRTMergeReferencedActivationFactoriesoption to merge all activation factories