Remove generated VftblPtr type #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
performance
Sergio0694
force-pushed
the
user/sergiopedri/remove-vftblptr-type
branch
2 times, most recently
from
e185a67 to
698fed3
Compare
jlaanstra
reviewed
Nov 30, 2023
Sergio0694
force-pushed
the
user/sergiopedri/remove-vftblptr-type
branch
from
f828a4c to
d2a737f
Compare
Sergio0694
force-pushed
the
user/sergiopedri/remove-vftblptr-type
branch
from
d2a737f to
58b81fd
Compare
Sergio0694
force-pushed
the
user/sergiopedri/remove-vftblptr-type
branch
from
58b81fd to
0bcf9e9
Compare
manodasanW
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the generated VftblType, which wasn't even used most of the time. The only code path referencing it has been rewritten to manually reinterpret a pointer instead of using
Marshal, which also makes it a bit faster while at it.