Rename HashProvider::Hash to HashProvider::hash#7660
Merged
Conversation
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename HashProvider::Hash to HashProvider::hash for consistency
Rename HashProvider::Hash to HashProvider::hash
Feb 10, 2026
Member
|
Flagged in #7651 (comment), this is the separate fix. |
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the ccf::crypto::HashProvider hashing API from Hash(...) to hash(...) to align method naming with the codebase’s prevailing style and updates all internal call sites and overrides accordingly.
Changes:
- Renamed the pure-virtual API in
HashProviderfromHashtohash. - Updated
OpenSSLHashProvideroverride tohash. - Updated all affected internal call sites (crypto key ops, RPC file serving, and benchmarks).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/ccf/crypto/hash_provider.h | Renames the public HashProvider interface method to hash. |
| src/crypto/openssl/hash.h | Renames OpenSSLHashProvider override to match the new interface. |
| src/crypto/openssl/ec_key_pair.cpp | Updates signing hash computation call sites. |
| src/crypto/openssl/ec_public_key.cpp | Updates verification hash computation call site. |
| src/crypto/openssl/rsa_key_pair.cpp | Updates RSA signing hash computation call site. |
| src/crypto/openssl/rsa_public_key.cpp | Updates RSA verify hash computation call site. |
| src/node/rpc/file_serving_handlers.h | Updates digest header computation to call hash. |
| src/crypto/test/bench.cpp | Updates benchmark to call hash. |
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
achamayou
approved these changes
Feb 10, 2026
maxtropets
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HashProvider::HashtoHashProvider::hashin base class (include/ccf/crypto/hash_provider.h)OpenSSLHashProvider::HashtoOpenSSLHashProvider::hashin subclass (src/crypto/openssl/hash.h)7.0.0-dev10→Changedsection (Rename HashProvider::Hash to HashProvider::hash #7660)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.