Skip to content

Rename HashProvider::Hash to HashProvider::hash#7660

Merged
achamayou merged 5 commits into
mainfrom
copilot/rename-hash-to-lowercase
Feb 11, 2026
Merged

Rename HashProvider::Hash to HashProvider::hash#7660
achamayou merged 5 commits into
mainfrom
copilot/rename-hash-to-lowercase

Conversation

Copilot AI commented Feb 10, 2026

Copy link
Copy Markdown
Contributor
  • Rename HashProvider::Hash to HashProvider::hash in base class (include/ccf/crypto/hash_provider.h)
  • Rename OpenSSLHashProvider::Hash to OpenSSLHashProvider::hash in subclass (src/crypto/openssl/hash.h)
  • Update all call sites (7 usages across crypto and RPC code)
  • Verify build compiles successfully
  • Add CHANGELOG.md entry under 7.0.0-dev10Changed section (Rename HashProvider::Hash to HashProvider::hash #7660)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename HashProvider::Hash to HashProvider::hash for consistency Rename HashProvider::Hash to HashProvider::hash Feb 10, 2026
Copilot AI requested a review from achamayou February 10, 2026 16:50
@achamayou achamayou marked this pull request as ready for review February 10, 2026 16:54
@achamayou achamayou requested a review from a team as a code owner February 10, 2026 16:54
Copilot AI review requested due to automatic review settings February 10, 2026 16:54
@achamayou

Copy link
Copy Markdown
Member

Flagged in #7651 (comment), this is the separate fix.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the ccf::crypto::HashProvider hashing API from Hash(...) to hash(...) to align method naming with the codebase’s prevailing style and updates all internal call sites and overrides accordingly.

Changes:

  • Renamed the pure-virtual API in HashProvider from Hash to hash.
  • Updated OpenSSLHashProvider override to hash.
  • Updated all affected internal call sites (crypto key ops, RPC file serving, and benchmarks).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
include/ccf/crypto/hash_provider.h Renames the public HashProvider interface method to hash.
src/crypto/openssl/hash.h Renames OpenSSLHashProvider override to match the new interface.
src/crypto/openssl/ec_key_pair.cpp Updates signing hash computation call sites.
src/crypto/openssl/ec_public_key.cpp Updates verification hash computation call site.
src/crypto/openssl/rsa_key_pair.cpp Updates RSA signing hash computation call site.
src/crypto/openssl/rsa_public_key.cpp Updates RSA verify hash computation call site.
src/node/rpc/file_serving_handlers.h Updates digest header computation to call hash.
src/crypto/test/bench.cpp Updates benchmark to call hash.

Comment thread include/ccf/crypto/hash_provider.h
Copilot AI and others added 2 commits February 10, 2026 17:08
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
@achamayou achamayou enabled auto-merge (squash) February 10, 2026 17:11
@achamayou achamayou merged commit ccd7ef6 into main Feb 11, 2026
23 of 25 checks passed
@achamayou achamayou deleted the copilot/rename-hash-to-lowercase branch February 11, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants