Remove unused enclave_offset logger paths#7491
Merged
Merged
Conversation
eddyashton
commented
Nov 28, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused enclave_offset parameter from logger methods. After PR #7224 removed the ringbuffer logging path, this parameter was always std::nullopt and is now being cleaned up.
Key changes:
- Simplified logger method signatures by removing the
enclave_offsetparameter - Removed conditional enclave timestamp formatting logic from
JsonConsoleLoggerandformat_to_text - Adjusted text log format spacing (removed 8-space padding that was used for alignment with enclave timestamps)
achamayou
approved these changes
Nov 28, 2025
achamayou
left a comment
achamayou
left a comment
Member
There was a problem hiding this comment.
Great, but needs a changelog entry!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7224 we removed the "log via the ringbuffer" path, which was the only place that would pass this
enclave_offsetarg. So it's always nullopt, and can be removed.