Added a ledger chunk class to manage the Transactions in a single chunk#1644
Merged
Conversation
achamayou
reviewed
Sep 24, 2020
achamayou
reviewed
Sep 24, 2020
achamayou
reviewed
Sep 24, 2020
achamayou
reviewed
Sep 24, 2020
achamayou
reviewed
Sep 24, 2020
achamayou
reviewed
Sep 24, 2020
achamayou
reviewed
Sep 24, 2020
Member
|
Thanks @msftsettiy, that change looks good! |
achamayou
approved these changes
Sep 24, 2020
Contributor
|
/azp run |
jumaffre
reviewed
Sep 24, 2020
|
master@13311 aka 20200929.38 vs master ewma over 50 builds from 12741 to 13311 |
Contributor
|
@msftsettiy Changes look good - thanks! Could you format It is the only test we have that uses the |
Contributor
|
/azp run |
Member
|
/azp run |
Member
|
@msftsettiy could you run './scripts/ci-checks.sh -f' to apply canonical formatting to your changes please? The PR is otherwise ready to merge. |
Member
|
/azp run |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR contains changes to split the Ledger class into two. The Ledger class is responsible for iterating over the ledger chunks and the Ledgerchunk class is responsible for iterating over the Transactions in a chunk.