Skip to content

Super linter pipeline fixes and fixes to mysql template and airlock_processor.tf#4847

Merged
marrobi merged 14 commits into
microsoft:mainfrom
JC-wk:super-linter-fixes
Feb 5, 2026
Merged

Super linter pipeline fixes and fixes to mysql template and airlock_processor.tf#4847
marrobi merged 14 commits into
microsoft:mainfrom
JC-wk:super-linter-fixes

Conversation

@JC-wk

@JC-wk JC-wk commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

Resolves #4846

What is being addressed

  • Fix TFLINT errors in pipeline
  • Fix for unused storage_mb param
  • Fix duplicated tf var TOPIC_SUBSCRIPTION_NAME
2026-02-04 13:38:25 [INFO]   Command output for TERRAFORM_TFLINT:
------
1 issue(s) found:

Warning: Duplicate key: "TOPIC_SUBSCRIPTION_NAME", first defined at airlock_processor.tf:83,5-30 (terraform_map_duplicate_keys)

  on airlock_processor.tf line 99:
  99:     "TOPIC_SUBSCRIPTION_NAME"         = azurerm_servicebus_subscription.airlock_processor.name

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.13.0/docs/rules/terraform_map_duplicate_keys.md

1 issue(s) found:

Warning: [Fixable] variable "storage_mb" is declared but not used (terraform_unused_declarations)

  on variables.tf line 16:
  16: variable "storage_mb" {

How is this addressed

  • Describe the changes made, and if appropriate, why they are addressed this way
  • Note any pending work (with links to the issues that will address them)
  • Update CHANGELOG.md
  • Increment versions

@JC-wk JC-wk requested a review from a team as a code owner February 4, 2026 13:41
@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 820bf88.

♻️ This comment has been updated with latest results.

@JC-wk JC-wk changed the title Super linter fixes Super linter fixes to mysql template and airlock_processor.tf Feb 4, 2026
@JC-wk JC-wk changed the title Super linter fixes to mysql template and airlock_processor.tf Super linter pipeline fixes and fixes to mysql template and airlock_processor.tf Feb 4, 2026
Comment thread .github/linters/.tflint_core.hcl Outdated
@marrobi

marrobi commented Feb 5, 2026

Copy link
Copy Markdown
Member

/test-extended

(given airlock subscription change_

@github-actions

github-actions Bot commented Feb 5, 2026

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/21706311183 (with refid 2fb76d34)

(in response to this comment from @marrobi)

@marrobi marrobi enabled auto-merge (squash) February 5, 2026 16:37
@marrobi

marrobi commented Feb 5, 2026

Copy link
Copy Markdown
Member

/test-force-approve

Failing on #1054 on delete.

@github-actions

github-actions Bot commented Feb 5, 2026

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 820bf88)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 9bf7561 into microsoft:main Feb 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mysql template ignores storage_mb param

3 participants