Skip to content

fix circular dependency in base workspace#4756

Merged
marrobi merged 5 commits into
microsoft:mainfrom
JC-wk:fix-circular-dependency
Nov 20, 2025
Merged

fix circular dependency in base workspace#4756
marrobi merged 5 commits into
microsoft:mainfrom
JC-wk:fix-circular-dependency

Conversation

@JC-wk

@JC-wk JC-wk commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator

Resolves #4741

What is being addressed

azurerm_subnet_network_security_group_association.webapps depends on itself

How is this addressed

  • change azurerm_subnet_network_security_group_association.webapps to depend on azurerm_subnet_network_security_group_association.services
  • Updated CHANGELOG.md
  • Incremented template version

@JC-wk JC-wk requested a review from a team as a code owner November 14, 2025 17:22
@github-actions

github-actions Bot commented Nov 14, 2025

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 5e02e55.

♻️ This comment has been updated with latest results.

@marrobi

marrobi commented Nov 17, 2025

Copy link
Copy Markdown
Member

/test-extended df36b5f

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/19431951749 (with refid ca182989)

(in response to this comment from @marrobi)

@marrobi marrobi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyry jonnyry self-requested a review November 18, 2025 12:38
@jonnyry

jonnyry commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator

/test-extended

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

⚠️ Cannot run tests as PR is not mergeable. Ensure that the PR is open and doesn't have any conflicts.

(in response to this comment from @jonnyry)

@jonnyry

jonnyry commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator

/test-extended df36b5f

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

⚠️ Cannot run tests as PR is not mergeable. Ensure that the PR is open and doesn't have any conflicts.

(in response to this comment from @jonnyry)

@marrobi

marrobi commented Nov 18, 2025

Copy link
Copy Markdown
Member

/test-extended d12237e

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/19468306954 (with refid ca182989)

(in response to this comment from @marrobi)

@marrobi

marrobi commented Nov 20, 2025

Copy link
Copy Markdown
Member

/test-extended d12237e

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/19534534798 (with refid ca182989)

(in response to this comment from @marrobi)

@marrobi

marrobi commented Nov 20, 2025

Copy link
Copy Markdown
Member

/test-force-approve 5e02e55

This causing e2e to fail: #3193

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 5e02e55)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 6973103 into microsoft:main Nov 20, 2025
13 checks passed
@JC-wk JC-wk deleted the fix-circular-dependency branch November 20, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

circular dependency in templates/workspaces/base/terraform/network/security.tf?

3 participants