Mark auth_client_secret variables as sensitive in terraform#4736
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 87e5327. ♻️ This comment has been updated with latest results. |
|
@marrobi I created a test which works locally but it doesn't seem like it's able to see the templates directory as it's current directory is api/. in the GitHub pipeline. |
It shoudl probably be called as part of: https://github.com/marrobi/AzureTRE/blob/e009b2497eb106d08018c86b86bbb0d5bf0d6831/Makefile#L253C1-L262 I'm happy with a @tamirkamara @jonnyry thoughts? |
|
I removed the test and created #4737 to allow discussion @marrobi @tamirkamara @jonnyry so this one can get sorted more quickly. |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/19171576697 (with refid (in response to this comment from @marrobi) |
|
/test 06785b2 |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/19466866239 (with refid (in response to this comment from @marrobi) |
|
/test-force-approve 87e5327 Passed: https://github.com/microsoft/AzureTRE/actions/runs/19466866239 |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 87e5327) (in response to this comment from @marrobi) |
Co-authored-by: Marcus Robinson <marrobi@microsoft.com>
Resolves #4735
What is being addressed
auth_client_secret leaks in log files if a deployment fails
How is this addressed