Add WORKSPACE_SERVICE_PREFIX to make user_resource_bundle#4731
Merged
Conversation
JC-wk
changed the title
WORKSPACE_SERVICE_PREFIX to make user_resource_bundle
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 74d46a9. ♻️ This comment has been updated with latest results. |
tamirkamara
reviewed
Oct 28, 2025
tamirkamara
left a comment
tamirkamara
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but I can't be the first approver. And, this PR is in draft.
Collaborator
Author
|
@tamirkamara thanks, I have set it to ready for review |
tamirkamara
approved these changes
Oct 30, 2025
marrobi
approved these changes
Oct 30, 2025
marrobi
left a comment
marrobi
left a comment
Member
There was a problem hiding this comment.
LGTM. Maybe needs to be in the docs/pipelines?
Collaborator
|
/test-force-approve 74d46a9 |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 74d46a9) (in response to this comment from @tamirkamara) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4721
What is being addressed
make user_resource_bundle doesn't work if your bundle is not named tre-service-{NAME}
How is this addressed
Add
WORKSPACE_SERVICE_PREFIXtomake user_resource_bundlefor use where a workspace-service bundle name does not start withtre-service-