update config_schema to add dns settings#4713
Closed
JC-wk wants to merge 2 commits into
Closed
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 9c47331. |
Collaborator
Author
|
If we go ahead with #4715 then this one would not be needed |
Member
|
Should we close this PR, or move it to Draft, if we'd rather apply #4715 instead? |
Member
|
Doh! It is draft!!!! Sorry. |
Collaborator
Author
|
Yeah happy to close it in favour of #4715 |
Collaborator
Author
|
closed in favour of #4715 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4712
What is being addressed
The schema is missing the newly added dns settings
How is this addressed