Skip to content

Fix: CI issue where branch names containing 'bootstrap'#4417

Merged
RonShakutai merged 3 commits into
mainfrom
fix-acr-skip-bootsrap-4416
Mar 10, 2025
Merged

Fix: CI issue where branch names containing 'bootstrap'#4417
RonShakutai merged 3 commits into
mainfrom
fix-acr-skip-bootsrap-4416

Conversation

@RonShakutai

Copy link
Copy Markdown
Collaborator

Resolves #4416

Updated the ACR login condition to check for 'make bootstrap' instead of just 'bootstrap' to avoid false positives.

@github-actions

github-actions Bot commented Mar 10, 2025

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0988a78.

♻️ This comment has been updated with latest results.

@RonShakutai RonShakutai requested review from LizaShak and marrobi March 10, 2025 10:55
@RonShakutai

Copy link
Copy Markdown
Collaborator Author

/test

@RonShakutai RonShakutai marked this pull request as ready for review March 10, 2025 11:05
@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13763114361 (with refid 4b645fa8)

(in response to this comment from @ShakutaiGit)

@RonShakutai RonShakutai self-assigned this Mar 10, 2025
@RonShakutai RonShakutai changed the title fix: update condition for Azure and ACR login to check for 'make bootsrap' Fix: CI issue where branch names containing 'bootstrap' Mar 10, 2025
@RonShakutai

Copy link
Copy Markdown
Collaborator Author

/test

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13763268486 (with refid 4b645fa8)

(in response to this comment from @ShakutaiGit)

@marrobi marrobi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RonShakutai RonShakutai removed the request for review from LizaShak March 10, 2025 12:00
@RonShakutai RonShakutai enabled auto-merge (squash) March 10, 2025 12:03
@RonShakutai

Copy link
Copy Markdown
Collaborator Author

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13763268486 (with refid 4b645fa8)

(in response to this comment from @ShakutaiGit)

Tests Passed

@RonShakutai

Copy link
Copy Markdown
Collaborator Author

/test-force-approve

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 0988a78)

(in response to this comment from @ShakutaiGit)

@RonShakutai RonShakutai merged commit ea0138c into main Mar 10, 2025
@RonShakutai RonShakutai deleted the fix-acr-skip-bootsrap-4416 branch March 10, 2025 12:32
marrobi pushed a commit to marrobi/AzureTRE that referenced this pull request May 20, 2025
* fix: update condition for Azure and ACR login to check for 'make bootstrap'

* fix: resolve CI issue with Azure login steps for branches containing 'bootstrap'
martinpeck pushed a commit that referenced this pull request May 20, 2025
* fix: update condition for Azure and ACR login to check for 'make bootstrap'

* fix: resolve CI issue with Azure login steps for branches containing 'bootstrap'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACR Login Skipped Due to 'bootstrap' Match in Branch Name

3 participants