Skip to content

FIx: show_output.sh #4413

Merged
RonShakutai merged 5 commits into
mainfrom
fix-wrapper-script-call
Mar 10, 2025
Merged

FIx: show_output.sh #4413
RonShakutai merged 5 commits into
mainfrom
fix-wrapper-script-call

Conversation

@RonShakutai

@RonShakutai RonShakutai commented Mar 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Resolves #4412

Summary of Changes:
Fix terraform output command by adding working directory parameter and updating terraform wrapper script

@RonShakutai

RonShakutai commented Mar 9, 2025

Copy link
Copy Markdown
Collaborator Author

/test

@github-actions

github-actions Bot commented Mar 9, 2025

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13747791637 (with refid 8de3e448)

(in response to this comment from @ShakutaiGit)

@github-actions

github-actions Bot commented Mar 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 48e6ee8.

♻️ This comment has been updated with latest results.

@RonShakutai

RonShakutai commented Mar 9, 2025

Copy link
Copy Markdown
Collaborator Author

/test

@github-actions

github-actions Bot commented Mar 9, 2025

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13747846373 (with refid 8de3e448)

(in response to this comment from @ShakutaiGit)

@RonShakutai RonShakutai self-assigned this Mar 9, 2025
@RonShakutai RonShakutai marked this pull request as ready for review March 9, 2025 12:27
@RonShakutai RonShakutai requested review from jonnyry and marrobi March 9, 2025 12:27
@RonShakutai

RonShakutai commented Mar 9, 2025

Copy link
Copy Markdown
Collaborator Author

/help

@github-actions

github-actions Bot commented Mar 9, 2025

Copy link
Copy Markdown

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @ShakutaiGit)

@RonShakutai

RonShakutai commented Mar 9, 2025

Copy link
Copy Markdown
Collaborator Author

/test-force-approve

@github-actions

github-actions Bot commented Mar 9, 2025

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ba4a8b9)

(in response to this comment from @ShakutaiGit)

@RonShakutai

RonShakutai commented Mar 9, 2025

Copy link
Copy Markdown
Collaborator Author

github.com/microsoft/AzureTRE/actions/runs/13747846373 (with refid 8de3e448)

(in response to this comment from @ShakutaiGit)

Tests passed here

marrobi
marrobi approved these changes Mar 10, 2025
View reviewed changes

@marrobi marrobi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please do changelog.

@RonShakutai

RonShakutai commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator Author

/test-force-approve

@github-actions

github-actions Bot commented Mar 10, 2025

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 48e6ee8)

(in response to this comment from @ShakutaiGit)

@RonShakutai RonShakutai merged commit f9918b3 into main Mar 10, 2025
@RonShakutai RonShakutai deleted the fix-wrapper-script-call branch March 10, 2025 11:24
marrobi pushed a commit to marrobi/AzureTRE that referenced this pull request May 20, 2025
@RonShakutai @marrobi
FIx: show_output.sh (microsoft#4413)
567c121 
* Update show_output.sh to use current directory and improve terraform_wrapper.sh usage documentation

* Bump version to 0.12.7

* Fix: update terraform output command to include working directory parameter and enhance wrapper script

* Fix: update changelog to correct formatting of terraform output command entry

* Fix: correct formatting of terraform output command entry in changelog
martinpeck pushed a commit that referenced this pull request May 20, 2025
@RonShakutai @martinpeck
FIx: show_output.sh (#4413)
466a71a 
* Update show_output.sh to use current directory and improve terraform_wrapper.sh usage documentation

* Bump version to 0.12.7

* Fix: update terraform output command to include working directory parameter and enhance wrapper script

* Fix: update changelog to correct formatting of terraform output command entry

* Fix: correct formatting of terraform output command entry in changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnyry jonnyry jonnyry approved these changes

@marrobi marrobi marrobi approved these changes

Assignees

@RonShakutai RonShakutai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Terraform wrapper script invoked without required parameters

3 participants

@RonShakutai @jonnyry @marrobi