Fix: storage account 403 error when creating new tre env by RonShakutai · Pull Request #4406 · microsoft/AzureTRE

RonShakutai · 2025-02-26T13:04:37Z

Resolves #4405

What is being addressed

Ensuring role propagation before execution: The script now properly waits for both Storage Account Contributor and Storage Blob Data Contributor roles to be assigned before attempting storage operations.
Refactoring role assignment check: Instead of checking a single role, the script now verifies both roles are assigned before proceeding, reducing failures due to role propagation delays.

Testing:

branch before the change (with the issue) https://github.com/microsoft/AzureTRE/actions/runs/13544133660
test of a new branch from the PR branch (after the change in the PR) https://github.com/microsoft/AzureTRE/actions/runs/13783862890 https://github.com/microsoft/AzureTRE/actions/runs/13767557310

…ntributor" and "Storage Account Contributor" roles

github-actions · 2025-02-26T13:05:21Z

Unit Test Results

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit c1e5441.

♻️ This comment has been updated with latest results.

…tor in bootstrap.sh

RonShakutai · 2025-02-26T14:12:48Z

/test

github-actions · 2025-02-26T14:13:04Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13545863577 (with refid ecb751e8)

(in response to this comment from @ShakutaiGit)

…ootstrap.sh

RonShakutai · 2025-03-10T15:57:18Z

/test

github-actions · 2025-03-10T15:57:34Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13769103068 (with refid ecb751e8)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-03-11T08:22:10Z

/test

github-actions · 2025-03-11T08:22:26Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13783417156 (with refid ecb751e8)

(in response to this comment from @ShakutaiGit)

…torage Blob Data Contributor

…hoing

…n bootstrap.sh

…sions in bootstrap.sh

marrobi

LGTM. Thanks tidy now.

RonShakutai · 2025-03-11T09:51:26Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13783417156 (with refid ecb751e8)

(in response to this comment from @ShakutaiGit)

tests passed

RonShakutai · 2025-03-11T09:52:30Z

/test-force-approve

github-actions · 2025-03-11T09:52:45Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit a60f169)

(in response to this comment from @ShakutaiGit)

…n in bootstrap.sh

…ta Contributor permissions in bootstrap.sh

RonShakutai · 2025-03-11T10:36:34Z

/test-force-approve

github-actions · 2025-03-11T10:36:50Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit c1e5441)

(in response to this comment from @ShakutaiGit)

) * Refactor role assignment check to validate both "Storage Blob Data Contributor" and "Storage Account Contributor" roles * Remove unused script source from bootstrap.sh * Refactor role assignment check to use local variables for clarity * Update CHANGELOG and add role assignment for Storage Account Contributor in bootstrap.sh * Refactor role assignment check to use counts for validation and streamline script execution * Refactor role assignment check to use non-empty value validation and enhance storage container creation with retry logic * CR changes * Refactor role assignment check to verify access via storage container list * Implement retry logic for role assignment checks in bootstrap script * Refactor check_terraform_role_assignments function to simplify error handling and remove unnecessary output * Enhance error message in check_terraform_role_assignments function to indicate retry mechanism on unexpected output * Remove unnecessary echo statement from retry_with_backoff function in bootstrap script * Add validation for required environment variables in bootstrap script * Refactor bootstrap script to streamline Terraform initialization and backend configuration * Add shellcheck disable comments for unbound variable warnings in bootstrap script * Update terraform_wrapper invocation and add blank line for readability in bootstrap script * Bump version to 0.12.7 in version.txt * Refactor bootstrap script to move backend configuration inline and remove redundant function * Remove redundant function call for writing bootstrap Terraform backend * Remove TODO comments from Terraform command output in bootstrap script * Bump version to 0.12.8 in version.txt * Bump version to 0.12.7 in version.txt * Refactor bootstrap script to inline backend configuration and improve error handling * fix: update condition for Azure and ACR login to check for 'make bootstrap' * fix: resolve CI issue with Azure login steps for branches containing 'bootstrap' * refactor: move Terraform backend configuration to a dedicated section in bootstrap.sh * fix: update role assignment to use Storage Blob Data Contributor in bootstrap.sh * fix: refine role assignment query in bootstrap.sh to check only for Storage Blob Data Contributor * fix: update role check in bootstrap.sh to return status instead of echoing * fix: update comment for granting Storage Blob Data Contributor role in bootstrap.sh * fix: update comment for granting Storage Blob Data Contributor permissions in bootstrap.sh

* Refactor role assignment check to validate both "Storage Blob Data Contributor" and "Storage Account Contributor" roles * Remove unused script source from bootstrap.sh * Refactor role assignment check to use local variables for clarity * Update CHANGELOG and add role assignment for Storage Account Contributor in bootstrap.sh * Refactor role assignment check to use counts for validation and streamline script execution * Refactor role assignment check to use non-empty value validation and enhance storage container creation with retry logic * CR changes * Refactor role assignment check to verify access via storage container list * Implement retry logic for role assignment checks in bootstrap script * Refactor check_terraform_role_assignments function to simplify error handling and remove unnecessary output * Enhance error message in check_terraform_role_assignments function to indicate retry mechanism on unexpected output * Remove unnecessary echo statement from retry_with_backoff function in bootstrap script * Add validation for required environment variables in bootstrap script * Refactor bootstrap script to streamline Terraform initialization and backend configuration * Add shellcheck disable comments for unbound variable warnings in bootstrap script * Update terraform_wrapper invocation and add blank line for readability in bootstrap script * Bump version to 0.12.7 in version.txt * Refactor bootstrap script to move backend configuration inline and remove redundant function * Remove redundant function call for writing bootstrap Terraform backend * Remove TODO comments from Terraform command output in bootstrap script * Bump version to 0.12.8 in version.txt * Bump version to 0.12.7 in version.txt * Refactor bootstrap script to inline backend configuration and improve error handling * fix: update condition for Azure and ACR login to check for 'make bootstrap' * fix: resolve CI issue with Azure login steps for branches containing 'bootstrap' * refactor: move Terraform backend configuration to a dedicated section in bootstrap.sh * fix: update role assignment to use Storage Blob Data Contributor in bootstrap.sh * fix: refine role assignment query in bootstrap.sh to check only for Storage Blob Data Contributor * fix: update role check in bootstrap.sh to return status instead of echoing * fix: update comment for granting Storage Blob Data Contributor role in bootstrap.sh * fix: update comment for granting Storage Blob Data Contributor permissions in bootstrap.sh

Refactor role assignment check to validate both "Storage Blob Data Co…

3c407d7

…ntributor" and "Storage Account Contributor" roles

Remove unused script source from bootstrap.sh

bdb0886

RonShakutai had a problem deploying to CICD February 26, 2025 13:07 — with GitHub Actions Error

Refactor role assignment check to use local variables for clarity

c421afb

RonShakutai changed the title ~~Refactor role assignment check to validate both "Storage Blob Data Co…~~ Fix: storage account 403 error when creating new tre env. Feb 26, 2025

RonShakutai had a problem deploying to CICD February 26, 2025 13:49 — with GitHub Actions Error

RonShakutai changed the title ~~Fix: storage account 403 error when creating new tre env.~~ Fix: storage account 403 error when creating new tre env Feb 26, 2025

RonShakutai temporarily deployed to CICD February 26, 2025 13:58 — with GitHub Actions Inactive

Update CHANGELOG and add role assignment for Storage Account Contribu…

52598a6

…tor in bootstrap.sh

RonShakutai temporarily deployed to CICD February 26, 2025 14:12 — with GitHub Actions Inactive

RonShakutai temporarily deployed to CICD February 26, 2025 14:20 — with GitHub Actions Inactive

LizaShak reviewed Mar 10, 2025

View reviewed changes

Comment thread .github/actions/devcontainer_run_command/action.yml

Comment thread devops/terraform/bootstrap.sh Outdated

RonShakutai removed the request for review from ashis-kar91 March 10, 2025 12:58

fix: update role assignment to use Storage Blob Data Contributor in b…

e40efd4

…ootstrap.sh

RonShakutai requested review from LizaShak, ashis-kar91 and marrobi March 10, 2025 15:56

RonShakutai added 4 commits March 11, 2025 08:39

fix: refine role assignment query in bootstrap.sh to check only for S…

d89b8e9

…torage Blob Data Contributor

fix: update role check in bootstrap.sh to return status instead of ec…

42a0ff8

…hoing

fix: update comment for granting Storage Blob Data Contributor role i…

578ae89

…n bootstrap.sh

fix: update comment for granting Storage Blob Data Contributor permis…

a60f169

…sions in bootstrap.sh

RonShakutai requested review from ashis-kar91 and removed request for ashis-kar91 March 11, 2025 09:13

marrobi approved these changes Mar 11, 2025

View reviewed changes

RonShakutai enabled auto-merge (squash) March 11, 2025 09:45

yuvalyaron approved these changes Mar 11, 2025

View reviewed changes

Comment thread devops/terraform/bootstrap.sh Outdated

Comment thread devops/terraform/bootstrap.sh Outdated

RonShakutai added 2 commits March 11, 2025 10:31

fix: update terraform initialization command to include backend optio…

141bcd6

…n in bootstrap.sh

fix: remove trailing period from comment for granting Storage Blob Da…

c1e5441

…ta Contributor permissions in bootstrap.sh

RonShakutai merged commit c2925cd into main Mar 11, 2025

RonShakutai deleted the fix-sa-bootstrap-err branch March 11, 2025 10:38

Conversation

RonShakutai commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolves #4405

What is being addressed

Uh oh!

github-actions Bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

RonShakutai commented Feb 26, 2025

Uh oh!

github-actions Bot commented Feb 26, 2025

Uh oh!

Uh oh!

Uh oh!

RonShakutai commented Mar 10, 2025

Uh oh!

github-actions Bot commented Mar 10, 2025

Uh oh!

RonShakutai commented Mar 11, 2025

Uh oh!

github-actions Bot commented Mar 11, 2025

Uh oh!

marrobi left a comment

Choose a reason for hiding this comment

Uh oh!

RonShakutai commented Mar 11, 2025

Uh oh!

RonShakutai commented Mar 11, 2025

Uh oh!

github-actions Bot commented Mar 11, 2025

Uh oh!

Uh oh!

Uh oh!

RonShakutai commented Mar 11, 2025

Uh oh!

github-actions Bot commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RonShakutai commented Feb 26, 2025 •

edited

Loading

github-actions Bot commented Feb 26, 2025 •

edited

Loading