Enable anonymous access in Nexus configuration script by RonShakutai · Pull Request #4387 · microsoft/AzureTRE

RonShakutai · 2025-02-20T15:57:08Z

Resolves #4361

Summary

This pull request refactors the Nexus configuration script to handle delays more gracefully and enables anonymous access once Nexus is confirmed to be ready.

What Is Being Addressed

Previously, the script tried to configure Nexus before it was fully ready, causing intermittent failures.
Anonymous access was not enabled in the original script.

How It Is Addressed

Exponential retry added
Wait for Configuration Directory Implemented
Wait for Nexus Service
Enable Anonymous Access
added configure_repo function

Evidence of service availability delay:

Tests

github-actions · 2025-02-20T15:58:03Z

Unit Test Results

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 3e7ca1b.

♻️ This comment has been updated with latest results.

RonShakutai · 2025-02-23T07:16:30Z

/test-extended

github-actions · 2025-02-23T07:16:45Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13480801966 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-02-24T09:53:38Z

/test-extended

github-actions · 2025-02-24T09:53:56Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13495247766 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-02-24T11:19:22Z

/test-extended

github-actions · 2025-02-24T11:19:41Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13496805569 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-02-24T15:58:15Z

/test-extended

github-actions · 2025-02-24T15:58:31Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13502255618 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-02-25T06:55:53Z

/test-extended

github-actions · 2025-02-25T06:56:05Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13515419105 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-02-25T10:13:00Z

/test

github-actions · 2025-02-25T10:13:18Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13518766607 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-02-25T10:41:29Z

/test

github-actions · 2025-02-25T10:41:47Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13519314802 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-02-25T10:44:34Z

/destroy-env

github-actions · 2025-02-25T10:44:48Z

🤖 pr-bot 🤖

/destroy-env is not recognised as a valid command.

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-02-25T10:46:39Z

/test-destroy-env

github-actions · 2025-02-25T10:47:30Z

Destroying branch test environment (RG: rg-tredcf4d668)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13519412407)

github-actions · 2025-02-25T10:47:31Z

Destroying PR test environment (RG: rg-tre6a231665)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13519412407)

github-actions · 2025-02-25T10:47:34Z

Branch test environment destroy complete (RG: rg-tredcf4d668)

RonShakutai · 2025-02-25T10:48:30Z

/test

github-actions · 2025-02-25T10:48:46Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13519447452 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

github-actions · 2025-02-25T11:26:21Z

PR test environment destroy complete (RG: rg-tre6a231665)

RonShakutai · 2025-02-26T09:09:36Z

/test

…Nexus access and retry logic

…cript

RonShakutai · 2025-03-12T16:40:49Z

/test

github-actions · 2025-03-12T16:41:05Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13816781272 (with refid 6a231665)

(in response to this comment from @ShakutaiGit)

marrobi

LGTM

Copilot

Pull Request Overview

This PR refactors the Nexus configuration script to handle delayed service readiness and enable anonymous access once Nexus is available. Key changes include:

Adding an exponential retry mechanism for handling Nexus availability delays.
Enabling anonymous access in the Nexus configuration.
Bumping the Nexus image version in the porter.yaml file.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
CHANGELOG.md	Updated changelog to document anonymous access enablement and the retry mechanism for Nexus.
templates/shared_services/sonatype-nexus-vm/porter.yaml	Updated the Nexus version from 3.3.2 to 3.3.3 to reflect the changes in the Nexus configuration.

RonShakutai · 2025-03-12T19:53:06Z

/test-force-approve

github-actions · 2025-03-12T19:53:21Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit a172957)

(in response to this comment from @ShakutaiGit)

RonShakutai · 2025-03-12T20:47:58Z

/test-destroy-env

github-actions · 2025-03-12T20:48:47Z

Destroying PR test environment (RG: rg-tre6a231665)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13821239944)

github-actions · 2025-03-12T20:48:55Z

Destroying branch test environment (RG: rg-tredcf4d668)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13821239944)

github-actions · 2025-03-12T20:49:00Z

Branch test environment destroy complete (RG: rg-tredcf4d668)

github-actions · 2025-03-12T21:11:39Z

PR test environment destroy complete (RG: rg-tre6a231665)

RonShakutai · 2025-03-15T19:32:41Z

/test-force-approve

github-actions · 2025-03-15T19:32:56Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 3e7ca1b)

(in response to this comment from @ShakutaiGit)

* Enable anonymous access in Nexus configuration script * Add role assignment for Storage Account Contributor in bootstrap script * Enhance role assignment check in bootstrap script to verify both "Storage Blob Data Contributor" and "Storage Account Contributor" roles are assigned * Refactor role assignment check to validate both "Storage Blob Data Contributor" and "Storage Account Contributor" roles * Remove unused script source from bootstrap.sh * Refactor role assignment check to use local variables for clarity * Update CHANGELOG and add role assignment for Storage Account Contributor in bootstrap.sh * Refactor role assignment check to use counts for validation and streamline script execution * Refactor role assignment check to use non-empty value validation and enhance storage container creation with retry logic * revert bootstrap * CR changes * Refactor role assignment check to verify access via storage container list * Implement retry logic for role assignment checks in bootstrap script * Refactor check_terraform_role_assignments function to simplify error handling and remove unnecessary output * Enhance error message in check_terraform_role_assignments function to indicate retry mechanism on unexpected output * Remove unnecessary echo statement from retry_with_backoff function in bootstrap script * Add validation for required environment variables in bootstrap script * Refactor bootstrap script to streamline Terraform initialization and backend configuration * Add shellcheck disable comments for unbound variable warnings in bootstrap script * Update terraform_wrapper invocation and add blank line for readability in bootstrap script * Bump version to 0.12.7 in version.txt * Refactor bootstrap script to move backend configuration inline and remove redundant function * Remove redundant function call for writing bootstrap Terraform backend * Update show_output.sh to use current directory and improve terraform_wrapper.sh usage documentation * Remove TODO comments from Terraform command output in bootstrap script * Bump version to 0.12.8 in version.txt * Bump version to 0.12.7 * Bump version to 0.12.7 in version.txt * Fix: simplify anonymous access configuration in Nexus repository script * Refactor bootstrap script to inline backend configuration and improve error handling * fix: update condition for Azure and ACR login to check for 'make bootstrap' * fix: resolve CI issue with Azure login steps for branches containing 'bootstrap' * refactor: move Terraform backend configuration to a dedicated section in bootstrap.sh * fix: update role assignment to use Storage Blob Data Contributor in bootstrap.sh * fix: refine role assignment query in bootstrap.sh to check only for Storage Blob Data Contributor * fix: update role check in bootstrap.sh to return status instead of echoing * fix: update comment for granting Storage Blob Data Contributor role in bootstrap.sh * fix: update comment for granting Storage Blob Data Contributor permissions in bootstrap.sh * fix: update Sonatype Nexus version and enhance repository configuration script with retry logic * fix: downgrade Sonatype Nexus version from 3.3.5 to 3.3.3 in porter.yaml * chore: update CHANGELOG.md to include enhancements and bug fixes for Nexus access and retry logic * fix: remove VS Code extensions proxy configuration from Nexus setup script * fix: update comment formatting in bootstrap.sh for clarity * refactor: rename functions for clarity in configure_nexus_repos.sh

Enable anonymous access in Nexus configuration script

c8b1806

Merge branch 'main' into nexus-bug-fix-4361

64654ce

Merge branch 'main' into nexus-bug-fix-4361

f4a7c46

Merge branch 'main' into nexus-bug-fix-4361

72ae38a

Merge branch 'main' into nexus-bug-fix-4361

c496ab2

RonShakutai added 2 commits March 12, 2025 13:20

chore: update CHANGELOG.md to include enhancements and bug fixes for …

2ee17ed

…Nexus access and retry logic

fix: remove VS Code extensions proxy configuration from Nexus setup s…

11068dc

…cript

RonShakutai requested review from LizaShak, marrobi and yuvalyaron March 12, 2025 16:24

RonShakutai marked this pull request as ready for review March 12, 2025 16:24

fix: update comment formatting in bootstrap.sh for clarity

a172957

marrobi approved these changes Mar 12, 2025

View reviewed changes

marrobi requested review from Copilot and jonnyry March 12, 2025 17:12

Copilot AI reviewed Mar 12, 2025

View reviewed changes

Comment thread CHANGELOG.md

yuvalyaron approved these changes Mar 13, 2025

View reviewed changes

Comment thread templates/shared_services/sonatype-nexus-vm/scripts/configure_nexus_repos.sh Outdated

refactor: rename functions for clarity in configure_nexus_repos.sh

3e7ca1b

RonShakutai merged commit 0248bcf into main Mar 15, 2025

RonShakutai deleted the nexus-bug-fix-4361 branch March 15, 2025 20:45

marrobi mentioned this pull request Apr 9, 2025

Nexus doesn't work until you log in as admin and enable anonymous usage #4475

Closed

mkava-barts mentioned this pull request Aug 15, 2025

Nexus needs an admin to enable anonymous access before it works Barts-Life-Science/AzureTRE#275

Closed

Conversation

RonShakutai commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolves #4361

Summary

What Is Being Addressed

How It Is Addressed

Tests

Uh oh!

github-actions Bot commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

RonShakutai commented Feb 23, 2025

Uh oh!

github-actions Bot commented Feb 23, 2025

Uh oh!

RonShakutai commented Feb 24, 2025

Uh oh!

github-actions Bot commented Feb 24, 2025

Uh oh!

RonShakutai commented Feb 24, 2025

Uh oh!

github-actions Bot commented Feb 24, 2025

Uh oh!

RonShakutai commented Feb 24, 2025

Uh oh!

github-actions Bot commented Feb 24, 2025

Uh oh!

RonShakutai commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

RonShakutai commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

RonShakutai commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

RonShakutai commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

RonShakutai commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

RonShakutai commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

github-actions Bot commented Feb 25, 2025

Uh oh!

RonShakutai commented Feb 26, 2025

Uh oh!

RonShakutai commented Mar 12, 2025

Uh oh!

github-actions Bot commented Mar 12, 2025

Uh oh!

marrobi left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

RonShakutai commented Mar 12, 2025

Uh oh!

github-actions Bot commented Mar 12, 2025

Uh oh!

RonShakutai commented Mar 12, 2025

Uh oh!

RonShakutai commented Feb 20, 2025 •

edited

Loading

github-actions Bot commented Feb 20, 2025 •

edited

Loading