Skip to content

Migrate UI to Vite build engine and update dependencies#4368

Merged
marrobi merged 10 commits into
microsoft:mainfrom
marrobi:marrobi/move-to-vite
Feb 17, 2025
Merged

Migrate UI to Vite build engine and update dependencies#4368
marrobi merged 10 commits into
microsoft:mainfrom
marrobi:marrobi/move-to-vite

Conversation

@marrobi

@marrobi marrobi commented Feb 12, 2025

Copy link
Copy Markdown
Member

Transition the UI from Create React App to Vite for improved build performance and modern features.

  • Create React App, and Build-scripts is no longer maintained and has variabilities.
  • Also introduces a typescript linter and prettier for code formatting.
  • Removes depreciated vscode linting commands as handled by extensions.
  • Linted the typescript.

Have tested the UI and all seems good.

@github-actions

github-actions Bot commented Feb 13, 2025

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 512eec6.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as ready for review February 13, 2025 16:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 87 out of 102 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .devcontainer/devcontainer.json: Language not supported
  • ui/app/.prettierrc: Language not supported
  • ui/app/index.html: Language not supported
  • ui/app/package.json: Language not supported
  • ui/app/public/index.html: Language not supported
  • ui/app/src/App.scss: Language not supported
  • ui/README.md: Evaluated as low risk
  • ui/app/README.md: Evaluated as low risk
  • ui/app/src/authConfig.ts: Evaluated as low risk
  • ui/app/src/components/root/RootDashboard.tsx: Evaluated as low risk
  • ui/app/src/components/shared/ConfirmCopyUrlToClipboard.tsx: Evaluated as low risk
  • ui/app/src/components/root/RootLayout.tsx: Evaluated as low risk
  • ui/app/src/App.test.tsx: Evaluated as low risk
  • ui/app/src/components/root/LeftNav.tsx: Evaluated as low risk
  • ui/app/src/components/shared/ConfirmDeleteResource.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)

ui/app/src/components/shared/CliCommand.tsx:33

  • The renderCommand function should return a valid React element even if commandMatches is null. Consider returning an empty fragment or a placeholder element.
return;

@marrobi marrobi requested a review from Copilot February 13, 2025 17:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 88 out of 103 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .devcontainer/devcontainer.json: Language not supported
  • ui/app/.prettierrc: Language not supported
  • ui/app/index.html: Language not supported
  • ui/app/package.json: Language not supported
  • ui/app/public/index.html: Language not supported
  • ui/app/src/App.scss: Language not supported
  • ui/README.md: Evaluated as low risk
  • ui/app/README.md: Evaluated as low risk
  • ui/app/src/authConfig.ts: Evaluated as low risk
  • CHANGELOG.md: Evaluated as low risk
  • ui/app/src/components/root/RootDashboard.tsx: Evaluated as low risk
  • ui/app/src/components/shared/ConfirmCopyUrlToClipboard.tsx: Evaluated as low risk
  • ui/app/src/App.test.tsx: Evaluated as low risk
  • ui/app/src/components/root/LeftNav.tsx: Evaluated as low risk
  • ui/app/src/components/root/RootLayout.tsx: Evaluated as low risk

@RonShakutai RonShakutai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Added one question about bandit, other than that its linting changes.

Comment thread .devcontainer/devcontainer.json
@marrobi marrobi requested review from LizaShak and jonnyry February 17, 2025 12:44
@marrobi marrobi enabled auto-merge (squash) February 17, 2025 12:51
@marrobi

marrobi commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

/test-force-approve

UI only.

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 512eec6)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit b416bd7 into microsoft:main Feb 17, 2025
@marrobi marrobi deleted the marrobi/move-to-vite branch February 17, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants