Fix upgrade if porter install has failed and add tests to resource processor#4338
Conversation
Unit Test Results21 tests 21 ✅ 0s ⏱️ Results for commit e686b4b. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- .devcontainer/devcontainer.json: Language not supported
- resource_processor/resources/helpers.py: Evaluated as low risk
- resource_processor/vmss_porter/runner.py: Evaluated as low risk
Comments suppressed due to low confidence (2)
resource_processor/helpers/commands.py:82
- Concatenation of porter_parameters should use += instead of reassignment for better performance and readability.
porter_parameters = f"{porter_parameters} --param {parameter_name}='{parameter_value}'"
resource_processor/helpers/commands.py:98
- Unnecessary f-string in command_line[0] assignment. It should be
command_line[0] += '--force-upgrade '.
command_line[0] = command_line[0] + f"{'--force-upgrade '}"
There was a problem hiding this comment.
Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- .devcontainer/devcontainer.json: Language not supported
- resource_processor/resources/helpers.py: Evaluated as low risk
- resource_processor/helpers/statuses.py: Evaluated as low risk
- resource_processor/_version.py: Evaluated as low risk
Comments suppressed due to low confidence (1)
resource_processor/helpers/commands.py:97
- The
--force-upgradeflag should be added to the command correctly. Consider appending it to thecommand_linelist.
if msg_body['action'] == 'upgrade':
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13243663390 (with refid (in response to this comment from @marrobi) |
1 similar comment
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13243663390 (with refid (in response to this comment from @marrobi) |
|
Failing on airlock with:
Seems like compute clock is an hour wrong or something. Will force approve as has deployed the workspaces etc, and watch for this again. |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit e686b4b) (in response to this comment from @marrobi) |
|
/test-destroy-env |
|
Destroying PR test environment (RG: rg-tre49cbdde2)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13252796384) |
Fixes #4281, #4291
resourcesnot liked by pytest).