Skip to content

Genericise Windows VM post install script to deal with different R versions#4289

Merged
jonnyry merged 3 commits into
microsoft:mainfrom
nwsde:jr/upstream-main/90-r-package-mirror
Feb 5, 2025
Merged

Genericise Windows VM post install script to deal with different R versions#4289
jonnyry merged 3 commits into
microsoft:mainfrom
nwsde:jr/upstream-main/90-r-package-mirror

Conversation

@jonnyry

@jonnyry jonnyry commented Jan 29, 2025

Copy link
Copy Markdown
Collaborator

Resolves #4288

What is being addressed

See #4288

@jonnyry jonnyry requested a review from marrobi January 29, 2025 12:42
@github-actions

github-actions Bot commented Jan 29, 2025

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0ba3a06.

♻️ This comment has been updated with latest results.

@jonnyry jonnyry requested a review from tamirkamara January 29, 2025 12:44

@marrobi marrobi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing you have tested it, LGTM.

@jonnyry jonnyry requested a review from LizaShak January 29, 2025 12:50
@jonnyry

jonnyry commented Feb 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-force-approve

not covered by CI test, tested locally

@github-actions

github-actions Bot commented Feb 5, 2025

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 0ba3a06)

(in response to this comment from @jonnyry)

@jonnyry jonnyry merged commit 8103f96 into microsoft:main Feb 5, 2025
@jonnyry jonnyry deleted the jr/upstream-main/90-r-package-mirror branch February 5, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows R version must be 4.1.2 otherwise post install script doesn't update package mirror URL

3 participants