Skip to content

Linux VM script fixes#4185

Merged
marrobi merged 4 commits into
mainfrom
marrobi/fix-color-profile-authentication
Dec 11, 2024
Merged

Linux VM script fixes#4185
marrobi merged 4 commits into
mainfrom
marrobi/fix-color-profile-authentication

Conversation

@marrobi

@marrobi marrobi commented Dec 11, 2024

Copy link
Copy Markdown
Member

Fixes #4184

  • Add a polkit rule to allow color profile creation without authentication in the Linux VM.
  • pre set vscode repo settings to prevent interactive dialog
  • remote restart command to ensure cloud config reports successful completion (it always failed as system would reboot)
  • move xrdp to end of script to prevent users connecting while installations in progress.

Fixes #4184

Add a polkit rule to allow color profile creation without authentication in the Linux VM.

* **vm_config.sh**
  - Add a new section to create a polkit rule to allow color profile creation without authentication.
  - Use the provided script to create the polkit rule.
  - Ensure the script is executed with sudo privileges.

* **CHANGELOG.md**
  - Add entry to the changelog referencing the issue number.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4184?shareId=XXXX-XXXX-XXXX-XXXX).
@github-actions

github-actions Bot commented Dec 11, 2024

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e457f60.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as draft December 11, 2024 13:46
@marrobi marrobi changed the title Fix color profile authentication required dialog in Linux VM Linux VM script fixes Dec 11, 2024
@marrobi marrobi marked this pull request as ready for review December 11, 2024 13:50

@tim-p-allen tim-p-allen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to update the resource version

@jonnyry jonnyry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not had chance to test but LGTM

@marrobi

marrobi commented Dec 11, 2024

Copy link
Copy Markdown
Member Author

/test-force-approve

Not covered by tests

@marrobi marrobi enabled auto-merge (squash) December 11, 2024 14:18
@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e457f60)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 6f4220f into main Dec 11, 2024
@marrobi marrobi deleted the marrobi/fix-color-profile-authentication branch December 11, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux VM generates authentication required to create a color profile dialog.

3 participants