Skip to content

Fix Dockerfile 'AS' casting#4170

Merged
marrobi merged 2 commits into
mainfrom
tamirkamara/fix-dockerfile-casting
Dec 9, 2024
Merged

Fix Dockerfile 'AS' casting#4170
marrobi merged 2 commits into
mainfrom
tamirkamara/fix-dockerfile-casting

Conversation

@tamirkamara

Copy link
Copy Markdown
Collaborator

What is being addressed

docker CLI runs some linting while building images. It alerts on some of the 'as' keyword casting.

How is this addressed

  • Use upper-case for 'FROM' and 'AS'

@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

Unit Test Results

632 tests   630 ✅  9s ⏱️
  6 suites    2 💤
  6 files      0 ❌

Results for commit ddf5b8f.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara requested a review from Copilot December 9, 2024 06:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (4)
  • airlock_processor/Dockerfile: Language not supported
  • api_app/Dockerfile: Language not supported
  • templates/workspace_services/guacamole/guacamole-server/docker/Dockerfile: Language not supported
  • templates/workspace_services/guacamole/guacamole-server/docker/version.txt: Language not supported

@tamirkamara

Copy link
Copy Markdown
Collaborator Author

/test-force-approve

@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit a75dfdd)

(in response to this comment from @tamirkamara)

@tamirkamara

Copy link
Copy Markdown
Collaborator Author

/test-force-approve

@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ddf5b8f)

(in response to this comment from @tamirkamara)

@marrobi marrobi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tim-p-allen tim-p-allen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi marrobi merged commit 0e30b9b into main Dec 9, 2024
@marrobi marrobi deleted the tamirkamara/fix-dockerfile-casting branch December 9, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants