Updates to all porter bundles to build docker images for amd64 platform from arm64 machines locally#3827
Conversation
…amd64 platform on arm64 dev machines
@microsoft-github-policy-service agree company="nhs" |
marrobi
left a comment
marrobi
left a comment
There was a problem hiding this comment.
One question, couple of find replace errors, thanks for looking into this.
|
/test-extended |
Unit Test Results588 tests 588 ✅ 7s ⏱️ Results for commit bbd19e2. ♻️ This comment has been updated with latest results. |
|
🤖 pr-bot 🤖
(in response to this comment from @marrobi) |
|
@marrobi - I don't see a way of addressing the lint warning where porter build encapsulates the docker build based on the suggested fix. Setting the --platform value as variable also doesn't stop it complaining. The only way around it is to include a hadolint.yaml with the following: ignored:
- DL3029 |
|
@m1p1h happy for you to add the ignore to |
|
@marrobi could we rerun the tests |
|
sorry - was some trailing white space..should be ok now |
|
/test-extended 7185718 |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7584785429 (with refid (in response to this comment from @marrobi) |
|
@m1p1h actually, missed, can you add an update to the changelog, just a simple one liner with reference the the PR. An unrelated dependency issue seems to have raised it's head. I'll try fix that while you update the changelog. Thanks. |
|
/test-extended 14dec54 |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7585457878 (with refid (in response to this comment from @marrobi) |
changelog updated |
|
/test-extended 1f3d4b2 |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7586142819 (with refid (in response to this comment from @marrobi) |
|
/test-extended 2d4817d |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7587163633 (with refid (in response to this comment from @marrobi) |
1 similar comment
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7587163633 (with refid (in response to this comment from @marrobi) |
|
/test-destroy-env |
|
Destroying PR test environment (RG: rg-trea27aa4c2)... (run: https://github.com/microsoft/AzureTRE/actions/runs/7613378501) |
|
PR test environment destroy complete (RG: rg-trea27aa4c2) |
|
/test-extended |
|
🤖 pr-bot 🤖
(in response to this comment from @marrobi) |
|
/test-extended 3ffb74dee |
|
🤖 pr-bot 🤖
(in response to this comment from @marrobi) |
|
/test-extended 2d4817d |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7613837987 (with refid (in response to this comment from @marrobi) |
|
/test-extended |
|
🤖 pr-bot 🤖
(in response to this comment from @marrobi) |
|
/test-extended bbd19e2 |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7624044675 (with refid (in response to this comment from @marrobi) |
|
@m1p1h thanks for the contribution. Took a bit of getting merged, weird dependency issue appeared, then our scheduled clean up script deleted the environment I was trying to redeploy to (I didn't realise this was the case), then a duplicate storage account ID which is rare but something we know about! |
3 participants
This update fixes #3823
What is being addressed
Porter bundles built on arm64 machines locally currently generate docker images for arm64 platforms (not amd64) which result in bundle deployment errors.
How is this addressed