Move to using managed identity for auth to CosmosDB. by marrobi · Pull Request #3806 · microsoft/AzureTRE

marrobi · 2023-12-06T09:43:12Z

Resolves #345

What is being addressed

Waiting on Logging PR #3762

Move to managed identity when connecting to the database when available.
Use same connect method for health checks.
Only attempt to create collection on bootstrap
Split out control plane and data plane operations as have different permissions model.
Create singleton database class to enable reuse of the cosmos client.
Update Change Log

github-actions · 2023-12-06T09:44:59Z

Unit Test Results

588 tests 588 ✅ 7s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit c33d9db.

♻️ This comment has been updated with latest results.

DragosDanielBoia · 2023-12-06T09:55:22Z

@microsoft-github-policy-service rerun

marrobi · 2023-12-07T17:08:17Z

/test-extended

github-actions · 2023-12-07T17:08:32Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7131558096 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2023-12-12T10:49:59Z

/test-destroy-env

github-actions · 2023-12-12T10:50:33Z

Destroying PR test environment (RG: rg-tre0a570b02)... (run: https://github.com/microsoft/AzureTRE/actions/runs/7180379175)

github-actions · 2023-12-12T11:09:20Z

PR test environment destroy complete (RG: rg-tre0a570b02)

marrobi · 2023-12-20T12:00:00Z

/test-extended

github-actions · 2023-12-20T12:00:15Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7275010888 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2023-12-20T17:41:40Z

/test-extended

github-actions · 2023-12-20T17:41:54Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7278921500 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2023-12-21T12:01:27Z

/test-extended

github-actions · 2023-12-21T12:01:41Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7287829909 (with refid 0a570b02)

(in response to this comment from @marrobi)

github-actions · 2023-12-21T12:55:10Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7287829909 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-02T15:43:44Z

/test-extended

github-actions · 2024-01-02T15:44:00Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7387658663 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-02T16:28:27Z

/test-extended

github-actions · 2024-01-02T16:28:43Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7388101965 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-02T17:24:53Z

/test-extended

github-actions · 2024-01-02T17:25:07Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7388651982 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-03T13:09:22Z

/test-extended

github-actions · 2024-01-03T13:09:36Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7397685388 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-03T14:03:08Z

/test-extended

github-actions · 2024-01-03T14:03:22Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7398222845 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-03T16:07:30Z

/test-extended

github-actions · 2024-01-03T16:07:44Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7399589965 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-03T16:16:17Z

/test-extended

github-actions · 2024-01-03T16:16:32Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7399691502 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-03T17:00:59Z

/test-extended

github-actions · 2024-01-03T17:01:16Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7400155369 (with refid 0a570b02)

(in response to this comment from @marrobi)

marrobi · 2024-01-03T22:43:00Z

/test-extended

github-actions · 2024-01-03T22:43:15Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7403210335 (with refid 0a570b02)

(in response to this comment from @marrobi)

Move to using managed identity for auth to CosmosDB.

5071e45

marrobi added 3 commits December 6, 2023 10:46

Add permissions to TRE DB to the API MSI

81ceb1e

Merge upstream

88b1f9b

Update CHANGELOG

4ff3dfe

marrobi marked this pull request as ready for review December 7, 2023 17:07

marrobi requested a review from damoodamoo December 7, 2023 17:08

damoodamoo approved these changes Dec 11, 2023

View reviewed changes

marrobi added 3 commits December 20, 2023 11:48

Add missing await and fix tests.

45a9fb7

update core version

3914d31

Update core version

fc2dd9a

remove DB create as this is done in terraform

5e7a417

split management plane and data plane operations.

97018a2

marrobi added 4 commits December 21, 2023 12:07

fix test

11f0f16

fix test

d0752e4

Refactor container creation.

c345aa2

remove import

0f6f592

Fix bad imports

4ff113e

fix reverted change

8e98ebf

Move get container into database class

df711f6

Remove await

f82fd06

marrobi added 2 commits January 3, 2024 15:35

tidy up credentials modifications

7dfc153

fix linting

90f7557

marrobi added 2 commits January 3, 2024 16:58

fix msi handling

18b651d

missed file.

2e95926

fix linting

c33d9db

marrobi enabled auto-merge (squash) January 3, 2024 17:11

marrobi merged commit 9c59b80 into microsoft:main Jan 4, 2024

marrobi deleted the marrobi/issue345 branch January 4, 2024 07:15

Conversation

marrobi commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolves #345

What is being addressed

Uh oh!

github-actions Bot commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

DragosDanielBoia commented Dec 6, 2023

Uh oh!

marrobi commented Dec 7, 2023

Uh oh!

github-actions Bot commented Dec 7, 2023

Uh oh!

marrobi commented Dec 12, 2023

Uh oh!

github-actions Bot commented Dec 12, 2023

Uh oh!

github-actions Bot commented Dec 12, 2023

Uh oh!

marrobi commented Dec 20, 2023

Uh oh!

github-actions Bot commented Dec 20, 2023

Uh oh!

marrobi commented Dec 20, 2023

Uh oh!

github-actions Bot commented Dec 20, 2023

Uh oh!

marrobi commented Dec 21, 2023

Uh oh!

github-actions Bot commented Dec 21, 2023

Uh oh!

github-actions Bot commented Dec 21, 2023

Uh oh!

marrobi commented Jan 2, 2024

Uh oh!

github-actions Bot commented Jan 2, 2024

Uh oh!

marrobi commented Jan 2, 2024

Uh oh!

github-actions Bot commented Jan 2, 2024

Uh oh!

marrobi commented Jan 2, 2024

Uh oh!

github-actions Bot commented Jan 2, 2024

Uh oh!

marrobi commented Jan 3, 2024

Uh oh!

github-actions Bot commented Jan 3, 2024

Uh oh!

marrobi commented Jan 3, 2024

Uh oh!

github-actions Bot commented Jan 3, 2024

Uh oh!

marrobi commented Jan 3, 2024

Uh oh!

github-actions Bot commented Jan 3, 2024

Uh oh!

marrobi commented Jan 3, 2024

Uh oh!

github-actions Bot commented Jan 3, 2024

Uh oh!

marrobi commented Jan 3, 2024

Uh oh!

github-actions Bot commented Jan 3, 2024

Uh oh!

marrobi commented Jan 3, 2024

Uh oh!

github-actions Bot commented Jan 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marrobi commented Dec 6, 2023 •

edited

Loading

github-actions Bot commented Dec 6, 2023 •

edited

Loading