Skip to content

Grey Box, Instead of Costs, Are Being Displayed in Web UI#3718

Merged
marrobi merged 4 commits into
microsoft:mainfrom
marrobi:marrobi/issue3254
Sep 21, 2023
Merged

Grey Box, Instead of Costs, Are Being Displayed in Web UI#3718
marrobi merged 4 commits into
microsoft:mainfrom
marrobi:marrobi/issue3254

Conversation

@marrobi

@marrobi marrobi commented Sep 21, 2023

Copy link
Copy Markdown
Member

Resolves #3254

How is this addressed

  • Only show cost tag when user has appropriate roles
  • Only show cost tag for resources wit costs implemented in the UI
  • Add clock and tooltip when costs are not yet available

@marrobi marrobi enabled auto-merge (squash) September 21, 2023 13:56
@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit dc5ac34.

♻️ This comment has been updated with latest results.

@marrobi marrobi requested a review from jjgriff93 September 21, 2023 13:57
@marrobi

marrobi commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

/test-force-approve

UI only

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 1558ce0)

(in response to this comment from @marrobi)

Comment thread ui/app/src/components/shared/CostsTag.tsx Outdated
Comment thread ui/app/src/components/shared/ResourceCard.tsx Outdated
Comment thread ui/app/src/components/shared/ResourceCard.tsx Outdated
Comment thread ui/app/src/components/shared/ResourceCard.tsx Outdated
Comment thread ui/app/src/components/shared/ResourceCard.tsx Outdated
Comment thread ui/app/src/components/shared/ResourceCard.tsx Outdated
Comment thread ui/app/src/components/shared/ResourceCard.tsx Outdated
@jjgriff93

Copy link
Copy Markdown
Contributor

And yes icons are initialised globally so you won't need that

@marrobi

marrobi commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

/test-force-approve

UI only.

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit dc5ac34)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 35a73a2 into microsoft:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grey Box, Instead of Costs, Are Being Displayed in Web UI

3 participants