Skip to content

Fix UI Failing to get workspaces for non workspace admin users#3499

Merged
yuvalyaron merged 5 commits into
microsoft:mainfrom
yuvalyaron:3489-fix-workspace-owners-and-researchers-receive-ui-error-on-get-workspaces
May 17, 2023
Merged

Fix UI Failing to get workspaces for non workspace admin users#3499
yuvalyaron merged 5 commits into
microsoft:mainfrom
yuvalyaron:3489-fix-workspace-owners-and-researchers-receive-ui-error-on-get-workspaces

Conversation

@yuvalyaron

@yuvalyaron yuvalyaron commented May 16, 2023

Copy link
Copy Markdown
Collaborator

Fixes #3489

  • Added missing enrichment in the the API
  • Although it shouldn't happen now, added validation in the UI to ensure that nonMajorUpgrades is not null

yuvalyaron added 2 commits May 16, 2023 12:58
@yuvalyaron
fix ui failing to get workspaces for non workspace admin users by add…
7ba383e 
…ing missing available upgrades enrichment + add validation in the UI
@yuvalyaron
refine fix
dee3499
@yuvalyaron yuvalyaron requested a review from martinpeck May 16, 2023 13:51
@github-actions

github-actions Bot commented May 16, 2023 •
edited
Loading

Copy link
Copy Markdown

Unit Test Results

574 tests   574 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 284206d.

♻️ This comment has been updated with latest results.

martinpeck
martinpeck approved these changes May 17, 2023
View reviewed changes

@martinpeck martinpeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this @yuvalyaron!

@yuvalyaron

yuvalyaron commented May 17, 2023

Copy link
Copy Markdown
Collaborator Author

/test

@yuvalyaron yuvalyaron enabled auto-merge (squash) May 17, 2023 07:17
@github-actions

github-actions Bot commented May 17, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5000453994 (with refid 18651ff0)

(in response to this comment from @yuvalyaron)

2 similar comments
@github-actions

github-actions Bot commented May 17, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5000453994 (with refid 18651ff0)

(in response to this comment from @yuvalyaron)

@github-actions

github-actions Bot commented May 17, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5000453994 (with refid 18651ff0)

(in response to this comment from @yuvalyaron)

@yuvalyaron

yuvalyaron commented May 17, 2023

Copy link
Copy Markdown
Collaborator Author

successful test run:
https://github.com/microsoft/AzureTRE/actions/runs/5004406367

@yuvalyaron

yuvalyaron commented May 17, 2023

Copy link
Copy Markdown
Collaborator Author

/test-force-approve

@github-actions

github-actions Bot commented May 17, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 284206d)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 48c06ec into microsoft:main May 17, 2023
@yuvalyaron yuvalyaron deleted the 3489-fix-workspace-owners-and-researchers-receive-ui-error-on-get-workspaces branch May 17, 2023 15:54
@github-actions

github-actions Bot commented May 17, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 284206d)

(in response to this comment from @yuvalyaron)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinpeck martinpeck martinpeck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Workspace Owners and Researchers receive a browser Error and cannot see workspaces

2 participants

@yuvalyaron @martinpeck