Skip to content

Add workflow default to RP_BUNDLE_VALUES#3444

Merged
tamirkamara merged 3 commits into
mainfrom
tamirkamara/fix-rp-bundle-var-default
Apr 17, 2023
Merged

Add workflow default to RP_BUNDLE_VALUES#3444
tamirkamara merged 3 commits into
mainfrom
tamirkamara/fix-rp-bundle-var-default

Conversation

@tamirkamara

@tamirkamara tamirkamara commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

What is being addressed

RP_BUNDLE_VALUES is an optional variable but its workflow default is an empty string (as is for any secret/var we use in the reusable workflow). That is invalid value in Terraform as the variable is defined as a map.

How is this addressed

  • Add {} as the workflow default for the param.

@tamirkamara tamirkamara requested a review from yuvalyaron April 16, 2023 13:36
@github-actions

github-actions Bot commented Apr 16, 2023 •
edited
Loading

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 430acb3.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review April 16, 2023 13:43
@tamirkamara

tamirkamara commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator Author

/test

@github-actions

github-actions Bot commented Apr 16, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4713636628 (with refid 86356437)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 13:57 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Apr 16, 2023 •
edited
Loading

Copy link
Copy Markdown

E2E Test Results

0 tests   - 25   0 ✔️  - 25   0s ⏱️ -6s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ❌ ±  0 

Results for commit 75c083a5. ± Comparison against base commit defdf76.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 13:59 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 14:03 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 14:13 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 14:33 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 14:36 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 14:47 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 14:58 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 15:05 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 16:49 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:16 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD April 16, 2023 17:19 — with GitHub Actions Inactive
@tamirkamara

tamirkamara commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions

github-actions Bot commented Apr 17, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4717772768 (with refid 86356437)

(in response to this comment from @tamirkamara)

@tamirkamara

tamirkamara commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions

github-actions Bot commented Apr 17, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4718285841 (with refid 86356437)

(in response to this comment from @tamirkamara)

damoodamoo
damoodamoo approved these changes Apr 17, 2023
View reviewed changes

@damoodamoo damoodamoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad face and many apologies from me :(

@tamirkamara

tamirkamara commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions

github-actions Bot commented Apr 17, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4718954057 (with refid 86356437)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damoodamoo damoodamoo damoodamoo approved these changes

@yuvalyaron yuvalyaron yuvalyaron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tamirkamara @damoodamoo @yuvalyaron