UI - Add Upgrade Button to Resources#3387
Merged
yuvalyaron merged 7 commits intoMar 30, 2023
Merged
Conversation
…8-ui-allow-users-to-upgrade-resources-non-major-versions
jjgriff93
approved these changes
Mar 30, 2023
jjgriff93
left a comment
jjgriff93
left a comment
Contributor
There was a problem hiding this comment.
Really great! UI for this looks very slick - just added some minor suggestions
Co-authored-by: James Griffin <me@JamesGriff.in>
…ions' of https://github.com/yuvalyaron/AzureTRE into 3118-ui-allow-users-to-upgrade-resources-non-major-versions
Collaborator
Author
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit f05145c) (in response to this comment from @yuvalyaron) |
yuvalyaron
deleted the
3118-ui-allow-users-to-upgrade-resources-non-major-versions
branch
LizaShak
added a commit
that referenced
this pull request
Apr 2, 2023
* UI - Add Upgrade Button to Resources (#3387) * add upgrade button to resources that can be upgraded (non major upgrades only) * update changelog * update ui version * fix cr review comments * Update ui/app/src/components/shared/ConfirmUpgradeResource.tsx Co-authored-by: James Griffin <me@JamesGriff.in> --------- Co-authored-by: James Griffin <me@JamesGriff.in> * Add comment on servicebus fqdn * Upgrade core version --------- Co-authored-by: Yuval Yaron <43217306+yuvalyaron@users.noreply.github.com> Co-authored-by: James Griffin <me@JamesGriff.in>
LizaShak
added a commit
that referenced
this pull request
Apr 2, 2023
* UI - Add Upgrade Button to Resources (#3387) * add upgrade button to resources that can be upgraded (non major upgrades only) * update changelog * update ui version * fix cr review comments * Update ui/app/src/components/shared/ConfirmUpgradeResource.tsx Co-authored-by: James Griffin <me@JamesGriff.in> --------- Co-authored-by: James Griffin <me@JamesGriff.in> * Upgrade core version --------- Co-authored-by: Yuval Yaron <43217306+yuvalyaron@users.noreply.github.com> Co-authored-by: James Griffin <me@JamesGriff.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3118
What is being addressed
Added
Upgradebutton to resources that have available template upgrades (only non major upgrades are considered)How is this addressed
availableUpgradewithforceUpdateRequired=false(non major upgrade)