Fix Private Endpoint DNS conflict in Airlock Review Workspace#3215
Merged
Conversation
Collaborator
Author
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 5e0825d) (in response to this comment from @tamirkamara) |
yuvalyaron
approved these changes
Feb 12, 2023
Collaborator
There was a problem hiding this comment.
I think it resolves issue #3181. Let's discuss it.
Collaborator
Author
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 0cc490e) (in response to this comment from @tamirkamara) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3144, #3181
What is being addressed
Sometimes the airlock processor will fail to transition a request to in_review. The underlining cause is a missing DNS config that would prevent the processor from reaching the in_progress storage account.
This situation is a result of the airlock-review workspace defining a private endpoint on the same storage account with the exact private_dns_zone_group. If the workspace would be deployed and then uninstalled, then the airlock processor would be left with the its own private endpoint but without the required private dns configuration needed to reach the storage account.
How is this addressed