Skip to content

Clean up review VMs for cancelled Airlock requests#3130

Merged
yuvalyaron merged 16 commits into
microsoft:mainfrom
yuvalyaron:2829-delete-review-vms-on-cancel
Jan 30, 2023
Merged

Clean up review VMs for cancelled Airlock requests#3130
yuvalyaron merged 16 commits into
microsoft:mainfrom
yuvalyaron:2829-delete-review-vms-on-cancel

Conversation

@yuvalyaron

@yuvalyaron yuvalyaron commented Jan 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Resolves #2829

What is being addressed

Review VMs are being cleaned up when an Airlock request is canceled.

How is this addressed

  • Moved the logic of cancelling airlock requests from the route to the service and added a call to delete review VMS
  • Added "disable VM" call to the method that deletes the review VM - this is necessary as disabling the resource might carry important logic, and this is what we force users to do in the UI (you can't delete a resource without disabling first).

@yuvalyaron yuvalyaron marked this pull request as ready for review January 26, 2023 16:02
@github-actions

github-actions Bot commented Jan 26, 2023 •
edited
Loading

Copy link
Copy Markdown

Unit Test Results

554 tests   554 ✔️  13s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit c48443b.

♻️ This comment has been updated with latest results.

tamirkamara
tamirkamara reviewed Jan 29, 2023
View reviewed changes
Comment thread api_app/_version.py Outdated
yuvalyaron and others added 2 commits January 29, 2023 10:19
@yuvalyaron @tamirkamara
Update api_app/_version.py
07827f5 
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@yuvalyaron
Merge branch 'main' into 2829-delete-review-vms-on-cancel
2324221
anatbal
anatbal reviewed Jan 29, 2023
View reviewed changes
Comment thread api_app/services/airlock.py
@yuvalyaron yuvalyaron requested a review from anatbal January 29, 2023 14:44
tamirkamara
tamirkamara reviewed Jan 30, 2023
View reviewed changes
Comment thread e2e_tests/test_airlock.py Outdated
anatbal
anatbal approved these changes Jan 30, 2023
View reviewed changes

@anatbal anatbal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron

yuvalyaron commented Jan 30, 2023

Copy link
Copy Markdown
Collaborator Author

/test

@yuvalyaron yuvalyaron enabled auto-merge (squash) January 30, 2023 12:52
@github-actions

github-actions Bot commented Jan 30, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4044009151 (with refid 664fed0d)

(in response to this comment from @yuvalyaron)

@yuvalyaron

yuvalyaron commented Jan 30, 2023

Copy link
Copy Markdown
Collaborator Author

/test

@github-actions

github-actions Bot commented Jan 30, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4044958579 (with refid 664fed0d)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 7f59c6c into microsoft:main Jan 30, 2023
@yuvalyaron yuvalyaron deleted the 2829-delete-review-vms-on-cancel branch January 30, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tamirkamara tamirkamara tamirkamara left review comments

@anatbal anatbal anatbal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up any review VMs if the request is cancelled

3 participants

@yuvalyaron @anatbal @tamirkamara