Validate required secrets have value#3073
Merged
Merged
Conversation
guybartal
requested changes
Jan 12, 2023
guybartal
left a comment
guybartal
left a comment
Collaborator
There was a problem hiding this comment.
required secret is missing in test: MS_TEAMS_WEBHOOK_URI
Collaborator
Author
It's not really missing since we sometimes remove the step that uses it (especially in the deployment repo) |
Collaborator
Author
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 7eac65d) (in response to this comment from @tamirkamara) |
guybartal
approved these changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
Some secrets must exist and have values, but something people forget to define them. In this case the errors might not be easy to understand.
An example issue: #2984
How is this addressed