Skip to content

add guacamole restrictions#2967

Merged
anatbal merged 12 commits into
mainfrom
fix/disabledownload
Jan 12, 2023
Merged

add guacamole restrictions#2967
anatbal merged 12 commits into
mainfrom
fix/disabledownload

Conversation

@eladiw

@eladiw eladiw commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

What is being addressed

Configure guacamole to have stricter rules

How is this addressed

@eladiw eladiw requested review from anatbal and marrobi December 15, 2022 09:00
@eladiw

eladiw commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

/test

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3702566079 (with refid 2adfed63)

(in response to this comment from @eladiw)

@github-actions

github-actions Bot commented Dec 15, 2022 •
edited
Loading

Copy link
Copy Markdown

Unit Test Results

15 tests   15 ✔️  2s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit 63494d8.

♻️ This comment has been updated with latest results.

marrobi
marrobi requested changes Dec 15, 2022
View reviewed changes
Comment thread templates/workspace_services/guacamole/guacamole-server/docker/guacamole/guacamole.properties Outdated
@eladiw

eladiw commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

/test-extended

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3702882254 (with refid 2adfed63)

(in response to this comment from @eladiw)

@eladiw

eladiw commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

/test-destroy-env

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

Destroying PR test environment (RG: rg-tre2adfed63)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3703204646)

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

Destroying branch test environment (RG: rg-tre00261096)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3703204646)

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

Branch test environment destroy complete (RG: rg-tre00261096)

@eladiw

eladiw commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

/test-extended

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3703212769 (with refid 2adfed63)

(in response to this comment from @eladiw)

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

PR test environment destroy complete (RG: rg-tre2adfed63)

@eladiw

eladiw commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

/test-extended

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3703554607 (with refid 2adfed63)

(in response to this comment from @eladiw)

@eladiw

eladiw commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

/test-destroy-env

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

Destroying PR test environment (RG: rg-tre2adfed63)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3704150929)

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

Destroying branch test environment (RG: rg-tre00261096)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3704150929)

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

Branch test environment destroy complete (RG: rg-tre00261096)

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

PR test environment destroy complete (RG: rg-tre2adfed63)

@eladiw

eladiw commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

/test

@github-actions

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3705971249 (with refid 2adfed63)

(in response to this comment from @eladiw)

@anatbal anatbal temporarily deployed to CICD January 12, 2023 13:52 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:23 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:23 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:23 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:25 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:47 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:50 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:53 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 14:56 — with GitHub Actions Inactive
@anatbal anatbal temporarily deployed to CICD January 12, 2023 15:03 — with GitHub Actions Inactive
@anatbal

anatbal commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

https://github.com/microsoft/AzureTRE/actions/runs/3896064292
Passed

@anatbal

anatbal commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

/test-force-approve

@github-actions

github-actions Bot commented Jan 12, 2023

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 63494d8)

(in response to this comment from @anatbal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tamirkamara tamirkamara tamirkamara left review comments

@anatbal anatbal anatbal approved these changes

@marrobi marrobi marrobi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eladiw @anatbal @marrobi @tamirkamara