Skip to content

Remove firewall rule when uninstalling Guacamole#2958

Merged
tamirkamara merged 3 commits into
mainfrom
tamirkamara/2776-guacamole-rule-uninstall
Dec 11, 2022
Merged

Remove firewall rule when uninstalling Guacamole#2958
tamirkamara merged 3 commits into
mainfrom
tamirkamara/2776-guacamole-rule-uninstall

Conversation

@tamirkamara

Copy link
Copy Markdown
Collaborator

Resolves #2776

What is being addressed

When uninstalling Guacamole, its firewall rule is left behind.

How is this addressed

  • Add the step to remove the rule (as we do in other templates)

@github-actions

github-actions Bot commented Dec 8, 2022

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 1bb32dd.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara force-pushed the tamirkamara/2776-guacamole-rule-uninstall branch from 630a15a to 15bf843 Compare December 8, 2022 15:08
@tamirkamara

Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions

github-actions Bot commented Dec 8, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3649524014 (with refid 5cfc590f)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) December 11, 2022 17:47
@tamirkamara

Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3670111066 (with refid 5cfc590f)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:29 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:34 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 18:36 — with GitHub Actions Inactive
@tamirkamara tamirkamara disabled auto-merge December 11, 2022 18:52
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:11 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:12 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:13 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:14 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:14 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:14 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:14 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:33 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 19:33 — with GitHub Actions Inactive
@tamirkamara tamirkamara enabled auto-merge (squash) December 11, 2022 20:15
@tamirkamara tamirkamara temporarily deployed to CICD December 11, 2022 20:18 — with GitHub Actions Inactive
@tamirkamara tamirkamara merged commit 26ffaae into main Dec 11, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2776-guacamole-rule-uninstall branch December 11, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninstalling guacamole ws service doesn't remove fw rules

2 participants