Skip to content

Support resource templateVersion update#2908

Merged
guybartal merged 38 commits into
microsoft:mainfrom
guybartal:guybartal/support-template-version-patching
Dec 4, 2022
Merged

Support resource templateVersion update#2908
guybartal merged 38 commits into
microsoft:mainfrom
guybartal:guybartal/support-template-version-patching

Conversation

@guybartal

@guybartal guybartal commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

Resolves #1744

What is being addressed

Add support for resource version updates.

How is this addressed

  • add templateVersion and 'forceVersionUpdate' properties to ResourcePatch model
  • update resource template version in cosmos db
  • block major version updates
  • block version downgrades
  • update github PR template
  • Update documentation
  • Update CHANGELOG.md if needed

@guybartal

guybartal commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator Author

/test

@github-actions

github-actions Bot commented Nov 24, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3542131615 (with refid d346fd55)

(in response to this comment from @guybartal)

@github-actions

github-actions Bot commented Nov 24, 2022 •
edited
Loading

Copy link
Copy Markdown

Unit Test Results

538 tests   538 ✔️  15s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit fde4d3e.

♻️ This comment has been updated with latest results.

tamirkamara
tamirkamara reviewed Nov 27, 2022
View reviewed changes

@tamirkamara tamirkamara left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to finally see this!

Comment thread api_app/_version.py Outdated
Comment thread docs/tre-workspace-authors/authoring-workspace-templates.md Outdated
Comment thread docs/tre-workspace-authors/authoring-workspace-templates.md Outdated
Comment thread docs/tre-workspace-authors/authoring-workspace-templates.md Outdated
Comment thread api_app/models/schemas/resource.py Outdated
Comment thread api_app/api/routes/shared_services.py Outdated
guybartal and others added 11 commits November 28, 2022 10:41
@guybartal @tamirkamara
Update api_app/_version.py
3deff17 
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@guybartal @tamirkamara
Update docs/tre-workspace-authors/authoring-workspace-templates.md
8db059b 
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@guybartal @tamirkamara
Update docs/tre-workspace-authors/authoring-workspace-templates.md
c4661ce 
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@guybartal @tamirkamara
Update docs/tre-workspace-authors/authoring-workspace-templates.md
9109aaf 
Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@guybartal
Merge branch 'main' into guybartal/support-template-version-patching
bd8a51b
@guybartal
disable linter rule MD046 inline
feda19c
@guybartal
linter issues
8525fdc
@guybartal
linter
c3d9a0d
@guybartal
remove logging
215fe45
@guybartal
move forceVersionUpdate fiield to query string
d4250b8
@guybartal
linter errors
65b1243
@guybartal guybartal temporarily deployed to CICD November 30, 2022 08:56 Inactive
@guybartal guybartal temporarily deployed to CICD November 30, 2022 08:58 Inactive
@guybartal

guybartal commented Nov 30, 2022

Copy link
Copy Markdown
Collaborator Author

/test-extended-aad

@github-actions

github-actions Bot commented Nov 30, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended AAD tests: https://github.com/microsoft/AzureTRE/actions/runs/3581860248 (with refid d346fd55)

(in response to this comment from @guybartal)

@tamirkamara tamirkamara changed the title Support template version update Support resource templateVersion update Dec 1, 2022
@guybartal

guybartal commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions

github-actions Bot commented Dec 4, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3612392671 (with refid d346fd55)

(in response to this comment from @guybartal)

@guybartal guybartal temporarily deployed to CICD December 4, 2022 08:56 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 09:01 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 09:01 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 09:01 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 09:01 Inactive
@guybartal guybartal temporarily deployed to CICD December 4, 2022 09:01 Inactive
@guybartal

guybartal commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator Author

/test-destroy-env

@github-actions

github-actions Bot commented Dec 4, 2022

Copy link
Copy Markdown

Destroying PR test environment (RG: rg-tred346fd55)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3612726924)

@github-actions

github-actions Bot commented Dec 4, 2022

Copy link
Copy Markdown

PR test environment destroy complete (RG: rg-tred346fd55)

@guybartal

guybartal commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions

github-actions Bot commented Dec 4, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3612799273 (with refid d346fd55)

(in response to this comment from @guybartal)

@guybartal

guybartal commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions

github-actions Bot commented Dec 4, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3613631441 (with refid d346fd55)

(in response to this comment from @guybartal)

@tamirkamara

tamirkamara commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator

/test-extended

@github-actions

github-actions Bot commented Dec 4, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3613819642 (with refid d346fd55)

(in response to this comment from @tamirkamara)

@tamirkamara

tamirkamara commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator

/test-extended

@github-actions

github-actions Bot commented Dec 4, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3614589339 (with refid d346fd55)

(in response to this comment from @tamirkamara)

@dusan-ilic-mhra dusan-ilic-mhra mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinpeck martinpeck martinpeck approved these changes

@tamirkamara tamirkamara tamirkamara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define mechanism for updating template version, and hence infrastructure of deployed workspaces, workspaces services and user resources

3 participants

@guybartal @tamirkamara @martinpeck