Airlock UI: support multiple review vms#2883
Merged
jjgriff93 merged 27 commits intoNov 29, 2022
Merged
Conversation
(apart from rsjf as next is in beta)
tanya-borisova
approved these changes
Nov 23, 2022
tanya-borisova
left a comment
Contributor
There was a problem hiding this comment.
The API part looks great!
Left some small nits / comments but up to you whether to apply them
Contributor
Author
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3575859656 (with refid (in response to this comment from @jjgriff93) |
https://github.com/microsoft/AzureTRE into jjgriff93/2764-airlock_ui-support_multiple_review_vms
Contributor
Author
|
/test-force-approve (no e2e changes wince test pass: https://github.com/microsoft/AzureTRE/actions/runs/3575859656) |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit d37da69) (in response to this comment from @jjgriff93) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2764
What is being addressed
This PR adds support in the API and UI for multiple reviewers being able to create review VMs for an airlock request. This also adds functionality for re-deploying a review resource if it's in a failed state and automatic clean-up of the previous resource.
How is this addressed