Skip to content

Airlock UI: create review VM#2769

Merged
jjgriff93 merged 18 commits into
mainfrom
jjgriff93/2738-airlock_ui-review_vm
Oct 21, 2022
Merged

Airlock UI: create review VM#2769
jjgriff93 merged 18 commits into
mainfrom
jjgriff93/2738-airlock_ui-review_vm

Conversation

@jjgriff93

Copy link
Copy Markdown
Contributor

Continuation of PR #2759 which has test environment conflicts

Resolves #2738
Resolves #2766

What is being addressed

Adds ability to deploy a review Vm in airlock review UI and open to view airlock request data securely in the review workspace

How is this addressed

  • Redesigned review experience as multi-step modal
  • Implemented create-review-vm endpoint
  • Display relevant resource state (created, not created, creating)
  • Added workspace scope option to componentManager hook so we can check for updates on resource that's in a different workspace to the current context (needed for import review Vms that reside in a different workspace)
  • Changed create-review-vm api endpoint to return airlock request as well as create vm operation to reduce calls and latency on front-end and potential state mismatch

image

image

image

Note: this only supports single review VMs currently. A follow-up story adds support for multiple reviewers' Vm resources: #2764

Also includes a small fix for filter switching #2766 and a fix for Nexus tf arguments error

@jjgriff93

Copy link
Copy Markdown
Contributor Author

/test

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3296838499 (with refid 7b646797)

(in response to this comment from @jjgriff93)

@github-actions

github-actions Bot commented Oct 21, 2022

Copy link
Copy Markdown

Unit Test Results

518 tests   518 ✔️  16s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 2c9a28a.

♻️ This comment has been updated with latest results.

@jjgriff93

Copy link
Copy Markdown
Contributor Author

Forcing test approval as previous test succeeded (https://github.com/microsoft/AzureTRE/actions/runs/3296838499) before merging minor change from main

@jjgriff93 jjgriff93 enabled auto-merge (squash) October 21, 2022 12:29
@jjgriff93

Copy link
Copy Markdown
Contributor Author

/test-force-approve

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 2c9a28a)

(in response to this comment from @jjgriff93)

@microsoft microsoft deleted a comment from github-actions Bot Oct 21, 2022
@jjgriff93 jjgriff93 merged commit 4e0342b into main Oct 21, 2022
@jjgriff93 jjgriff93 deleted the jjgriff93/2738-airlock_ui-review_vm branch October 21, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airlock UI - clicking between quick filters doesn't clear previous filters UI for Airlock Review VM

2 participants