Airlock UI: create review VM#2769
Merged
Merged
Conversation
…com/microsoft/AzureTRE into jjgriff93/2738-airlock_ui-review_vm
tanya-borisova
approved these changes
Oct 21, 2022
Contributor
Author
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3296838499 (with refid (in response to this comment from @jjgriff93) |
…com/microsoft/AzureTRE into jjgriff93/2738-airlock_ui-review_vm
Contributor
Author
|
Forcing test approval as previous test succeeded (https://github.com/microsoft/AzureTRE/actions/runs/3296838499) before merging minor change from main |
Contributor
Author
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 2c9a28a) (in response to this comment from @jjgriff93) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of PR #2759 which has test environment conflicts
Resolves #2738
Resolves #2766
What is being addressed
Adds ability to deploy a review Vm in airlock review UI and open to view airlock request data securely in the review workspace
How is this addressed
Note: this only supports single review VMs currently. A follow-up story adds support for multiple reviewers' Vm resources: #2764
Also includes a small fix for filter switching #2766 and a fix for Nexus tf arguments error