TRE CLI in devcontainer#2757
Merged
Merged
Conversation
stuartleeks
approved these changes
Oct 19, 2022
stuartleeks
left a comment
stuartleeks
left a comment
Contributor
There was a problem hiding this comment.
A couple of comments, but otherwise LGTM
Co-authored-by: Stuart Leeks <stuartle@microsoft.com>
Collaborator
Author
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3281332836 (with refid (in response to this comment from @tamirkamara) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
We currently install the TRE CLI on every "create" of the container. In the CI this method creates some noise as every time we execute a container command we also need to install the CLI.
How is this addressed