Skip to content

User resource template for export review vm#2699

Merged
tanya-borisova merged 11 commits into
mainfrom
tborisova/2602-user-resource-template-for-export-review-vm
Oct 4, 2022
Merged

User resource template for export review vm#2699
tanya-borisova merged 11 commits into
mainfrom
tborisova/2602-user-resource-template-for-export-review-vm

Conversation

@tanya-borisova

Copy link
Copy Markdown
Contributor

Resolves #2602

What is being addressed

Created a user resource template for Export review VM

How is this addressed

  • Added a Network Security group to the windowsvm template
  • Added rules denying outbound traffic from the review VM
  • Added rules allowing connection to in-review export storage account
  • Tested in an environment that can connect to storage account
  • Tested that can't connect to other VMs from review VM (via telnet, same test on research VMs succeeds)

@tanya-borisova tanya-borisova linked an issue Oct 3, 2022 that may be closed by this pull request
@github-actions

github-actions Bot commented Oct 3, 2022

Copy link
Copy Markdown

Unit Test Results

0 tests   - 17   0 ✔️  - 17   0s ⏱️ -8s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ±  0 

Results for commit 3a1f7b4. ± Comparison against base commit bc065c8.

♻️ This comment has been updated with latest results.

…-vm' of github.com:microsoft/AzureTRE into tborisova/2602-user-resource-template-for-export-review-vm

@martinpeck martinpeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment

@tanya-borisova

Copy link
Copy Markdown
Contributor Author

/test-force-approve

No tests on this as it's a new template

@github-actions

github-actions Bot commented Oct 4, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 3a1f7b4)

(in response to this comment from @tanya-borisova)

@tanya-borisova tanya-borisova merged commit 5dc48d7 into main Oct 4, 2022
@tanya-borisova tanya-borisova deleted the tborisova/2602-user-resource-template-for-export-review-vm branch October 4, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User resource template for Export Review VM

2 participants