Align Github secret names#2655
Merged
Merged
Conversation
LizaShak
approved these changes
Sep 28, 2022
tamirkamara
force-pushed
the
tamirkamara/align-secret-names
branch
from
f40c974 to
7003575
Compare
Collaborator
Author
|
/test-extended |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
On Github we use different names for secrets compared with their .env names. This creates confusion and mistakes.
Migration
MGMT_RESOURCE_GROUPtoMGMT_RESOURCE_GROUP_NAMESTATE_STORAGE_ACCOUNT_NAMEtoMGMT_STORAGE_ACCOUNT_NAMETF_STATE_CONTAINER, then delete this secret. If not, you need to rename it toTERRAFORM_STATE_CONTAINER_NAMEHow is this addressed