Skip to content

Remove manual (makefile) install option for Gitea and Nexus#2573

Merged
tamirkamara merged 4 commits into
mainfrom
tamirkamara/2425-remove-manual-nexus-gitea-install
Sep 8, 2022
Merged

Remove manual (makefile) install option for Gitea and Nexus#2573
tamirkamara merged 4 commits into
mainfrom
tamirkamara/2425-remove-manual-nexus-gitea-install

Conversation

@tamirkamara

@tamirkamara tamirkamara commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator

Resolves #2425

What is being addressed

We documented a way to install Gitea and Nexus shared services manually by the makefile. Since this option isn't advised anymore we need to remove it.

How is this addressed

  • Remove relevant options from makefile and core .env file
  • Update documentation to install with the UI/API
  • Remove other obsolete options from the core .env file

@github-actions

github-actions Bot commented Sep 8, 2022

Copy link
Copy Markdown

Unit Test Results

0 tests   - 3   0 ✔️  - 1   0s ⏱️ - 1h 2m 36s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0  - 2 

Results for commit f80cd87. ± Comparison against base commit 6fd2e33.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review September 8, 2022 15:45
@tamirkamara

Copy link
Copy Markdown
Collaborator Author

/test

@tamirkamara tamirkamara enabled auto-merge (squash) September 8, 2022 15:45
@github-actions

github-actions Bot commented Sep 8, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3016435560 (with refid bc9006b9)

(in response to this comment from @tamirkamara)

@tamirkamara

Copy link
Copy Markdown
Collaborator Author

/test

@github-actions

github-actions Bot commented Sep 8, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3017001535 (with refid bc9006b9)

(in response to this comment from @tamirkamara)

@marrobi marrobi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara tamirkamara merged commit bfa5274 into main Sep 8, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2425-remove-manual-nexus-gitea-install branch September 8, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove installation of Gitea and Nexus from the make file

2 participants