Issue admin token on demand to avoid an expired token in e2e tests by eladiw · Pull Request #2572 · microsoft/AzureTRE

eladiw · 2022-09-08T13:38:04Z

Resolves #2546

What is being addressed

Fixed API app throwing 500 when getting invalid token.
made e2e tests more stable, but re-issuing the access token when needed.

…e tests

eladiw · 2022-09-08T14:19:28Z

/test

github-actions · 2022-09-08T14:19:44Z

🤖 pr-bot 🤖

⚠️ Cannot run tests as PR is not mergeable. Ensure that the PR is open and doesn't have any conflicts.

(in response to this comment from @eladiw)

…e tests

eladiw · 2022-09-08T14:25:07Z

/test-extended

github-actions · 2022-09-08T14:25:28Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3015867371 (with refid 6c7829a2)

(in response to this comment from @eladiw)

github-actions · 2022-09-08T14:25:39Z

Unit Test Results

503 tests +501 501 ✔️ +499 11s ⏱️ - 1h 13m 55s
    1 suites ±    0     2 💤 +    2
    1 files ±    0     0 ❌ ±    0

Results for commit 93393c2. ± Comparison against base commit 60057c3.

This pull request removes 2 and adds 503 tests. Note that renamed tests count towards both.

test_airlock ‑ test_airlock_import_flow
test_workspace_services ‑ test_create_guacamole_service_into_base_workspace

tests_ma.test_api.test_errors.test_422_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_errors.test_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_approves_airlock_request_returns_200
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_input_is_malformed_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_event_grid_not_responding_returns_503
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_illegal_status_change_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_cancelled_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_in_progress_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_airlock_request_found_returns_404
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_workspace_request_found_returns_404
…

♻️ This comment has been updated with latest results.

eladiw · 2022-09-08T15:42:38Z

/test-extended

github-actions · 2022-09-08T15:43:27Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3016415474 (with refid 6c7829a2)

(in response to this comment from @eladiw)

eladiw · 2022-09-08T16:21:41Z

/help

github-actions · 2022-09-08T16:22:04Z

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @eladiw)

eladiw · 2022-09-08T16:22:15Z

/test-destroy-env

github-actions · 2022-09-08T16:24:14Z

Destroying PR test environment (RG: rg-tre6c7829a2)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3016677144)

github-actions · 2022-09-08T16:24:30Z

Destroying branch test environment (RG: rg-tre627f899e)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3016677144)

github-actions · 2022-09-08T16:24:32Z

Branch test environment destroy complete (RG: rg-tre627f899e)

github-actions · 2022-09-08T16:42:39Z

PR test environment destroy complete (RG: rg-tre6c7829a2)

eladiw · 2022-09-08T16:47:26Z

/test-extended

github-actions · 2022-09-08T16:47:48Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3016823757 (with refid 6c7829a2)

(in response to this comment from @eladiw)

eladiw · 2022-09-08T18:16:30Z

/test-destroy-env

github-actions · 2022-09-08T18:17:15Z

Destroying PR test environment (RG: rg-tre6c7829a2)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3017338115)

github-actions · 2022-09-08T18:17:19Z

Destroying branch test environment (RG: rg-tre627f899e)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3017338115)

github-actions · 2022-09-08T18:17:21Z

Branch test environment destroy complete (RG: rg-tre627f899e)

eladiw · 2022-09-08T18:34:01Z

/test-extended

github-actions · 2022-09-08T18:34:18Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3017439046 (with refid 6c7829a2)

(in response to this comment from @eladiw)

github-actions · 2022-09-08T18:34:38Z

PR test environment destroy complete (RG: rg-tre6c7829a2)

eladiw · 2022-09-11T05:57:16Z

/test-extended

github-actions · 2022-09-11T05:57:30Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3030711680 (with refid 6c7829a2)

(in response to this comment from @eladiw)

github-actions · 2022-09-11T13:45:42Z

Destroying branch test environment (RG: rg-tre627f899e)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3032037492)

github-actions · 2022-09-11T13:45:44Z

Branch test environment destroy complete (RG: rg-tre627f899e)

github-actions · 2022-09-11T14:01:34Z

PR test environment destroy complete (RG: rg-tre6c7829a2)

eladiw · 2022-09-11T14:02:51Z

/test-extended

github-actions · 2022-09-11T14:03:10Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3032092031 (with refid 6c7829a2)

(in response to this comment from @eladiw)

eladiw · 2022-09-11T14:38:58Z

/test-destroy-env

github-actions · 2022-09-11T14:39:34Z

Destroying branch test environment (RG: rg-tre627f899e)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3032204857)

github-actions · 2022-09-11T14:39:34Z

Destroying PR test environment (RG: rg-tre6c7829a2)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3032204857)

github-actions · 2022-09-11T14:39:35Z

Branch test environment destroy complete (RG: rg-tre627f899e)

github-actions · 2022-09-11T14:56:50Z

PR test environment destroy complete (RG: rg-tre6c7829a2)

eladiw · 2022-09-11T15:01:20Z

/test-extended

github-actions · 2022-09-11T15:01:33Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3032272619 (with refid 6c7829a2)

(in response to this comment from @eladiw)

eladiw · 2022-09-11T16:16:43Z

/test

github-actions · 2022-09-11T16:17:02Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3032498244 (with refid 6c7829a2)

(in response to this comment from @eladiw)

eladiw · 2022-09-11T16:20:07Z

/test

github-actions · 2022-09-11T16:20:20Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3032507600 (with refid 6c7829a2)

(in response to this comment from @eladiw)

github-actions · 2022-09-11T18:35:36Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3032507600 (with refid 6c7829a2)

(in response to this comment from @eladiw)

eladiw · 2022-09-11T19:15:54Z

/test-extended

github-actions · 2022-09-11T19:16:07Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3033016018 (with refid 6c7829a2)

(in response to this comment from @eladiw)

github-actions · 2022-09-11T20:24:45Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3033016018 (with refid 6c7829a2)

(in response to this comment from @eladiw)

eladiw · 2022-09-11T20:41:17Z

/test-extended

eladiw · 2022-09-12T04:09:59Z

/test

github-actions · 2022-09-12T04:10:13Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3034606049 (with refid 6c7829a2)

(in response to this comment from @eladiw)

draft - admin token is retrieved via direct method call in some of th…

b6d1dac

…e tests

eladiw changed the title ~~draft - admin token is retrieved via direct method call in some of th…~~ Issue admin token on demand to avoid an expired token in e2e tests Sep 8, 2022

draft - admin token is retrieved via direct method call in some of th…

479b294

…e tests

eladiw force-pushed the elad/issue2546 branch from b6d1dac to 479b294 Compare September 8, 2022 14:24

refactoring

68c06d9

Merge branch 'main' into elad/issue2546

9203454

update version

05acad0

raising informative http exceptions on token validation errors

93393c2

eladiw enabled auto-merge (squash) September 11, 2022 22:03

tamirkamara approved these changes Sep 12, 2022

View reviewed changes

eladiw merged commit 913f11a into main Sep 12, 2022

eladiw deleted the elad/issue2546 branch September 12, 2022 04:41

Conversation

eladiw commented Sep 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolves #2546

What is being addressed

Uh oh!

eladiw commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

eladiw commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

eladiw commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

eladiw commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

eladiw commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

eladiw commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

eladiw commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

eladiw commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

github-actions Bot commented Sep 8, 2022

Uh oh!

eladiw commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

eladiw commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

eladiw commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

github-actions Bot commented Sep 11, 2022

Uh oh!

eladiw commented Sep 11, 2022

Uh oh!

eladiw commented Sep 8, 2022 •

edited

Loading

github-actions Bot commented Sep 8, 2022 •

edited

Loading