Airlock UI: view requests (workspace-level)#2512
Merged
Merged
Conversation
damoodamoo
reviewed
Aug 30, 2022
damoodamoo
left a comment
damoodamoo
left a comment
Member
There was a problem hiding this comment.
Overall it's looking great - and like the visual changes too. A few nits and questions including one or two for Marcus, but nice work!
tamirkamara
reviewed
Aug 31, 2022
damoodamoo
approved these changes
Sep 1, 2022
Member
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 5a35723) (in response to this comment from @damoodamoo) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2509
What is being addressed
This adds a component to view the airlock requests (currently at the workspace-level) in a list with sorting options. It also adds a component to view an individual request with all its details, as well as providing actions for submitting a draft request and cancelling a request. Includes some visual tweaks to bring UI closer to figma designs.
How it is addressed