Guacamole sends logs to app insights#2376
Merged
tamirkamara merged 4 commits intoJul 31, 2022
Merged
Conversation
anatbal
approved these changes
Jul 31, 2022
anatbal
left a comment
anatbal
left a comment
Contributor
There was a problem hiding this comment.
Looks good, minor comment
Collaborator
Author
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2769229971 (with refid (in response to this comment from @tamirkamara) |
Collaborator
Author
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2769523750 (with refid (in response to this comment from @tamirkamara) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1938
What is being addressed
Guacamole logs weren't being sent to app insights since we didn't have one in the workspace level, which we do now...
How is this addressed