Skip to content

Adding Airlock Manager Role - Part I#2349

Merged
anatbal merged 31 commits into
microsoft:mainfrom
anatbal:feature/airlock-manager-role
Aug 2, 2022
Merged

Adding Airlock Manager Role - Part I#2349
anatbal merged 31 commits into
microsoft:mainfrom
anatbal:feature/airlock-manager-role

Conversation

@anatbal

@anatbal anatbal commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Part 1 of #2269

Fixes #2380

What is being addressed

  • Adding new airlock manager role
  • Allowing only airlock manager to review airlock request
  • Edit unit tests to work with the new role

@github-actions

github-actions Bot commented Jul 26, 2022

Copy link
Copy Markdown

Unit Test Results

467 tests   465 ✔️  12s ⏱️
    1 suites      2 💤
    1 files        0

Results for commit e334656.

♻️ This comment has been updated with latest results.

@anatbal anatbal force-pushed the feature/airlock-manager-role branch from 8862457 to ecd559d Compare July 26, 2022 15:53
@anatbal anatbal marked this pull request as ready for review July 27, 2022 14:03
@anatbal anatbal requested a review from LizaShak July 27, 2022 14:03
@anatbal anatbal force-pushed the feature/airlock-manager-role branch from 6a1445e to e996ab4 Compare July 27, 2022 14:05
Comment thread api_app/api/routes/airlock.py
Comment thread templates/workspaces/base/porter.yaml Outdated
@anatbal

anatbal commented Jul 28, 2022

Copy link
Copy Markdown
Contributor Author

/test-extended

@github-actions

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2753546656 (with refid 85319da0)

(in response to this comment from @anatbal)

@anatbal

anatbal commented Jul 31, 2022

Copy link
Copy Markdown
Contributor Author

/test-extended

@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:42 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:43 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:43 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:43 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:43 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:43 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:43 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:44 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:44 Inactive
@anatbal anatbal temporarily deployed to CICD July 31, 2022 16:44 Inactive
@anatbal

anatbal commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

/test-extended

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2780499397 (with refid 85319da0)

(in response to this comment from @anatbal)

@anatbal

anatbal commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

/test-destroy-env

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

Destroying PR test environment (RG: rg-tre85319da0)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2780579260)

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

PR test environment destroy complete (RG: rg-tre85319da0)

@anatbal

anatbal commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

/test-extended

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2780650792 (with refid 85319da0)

(in response to this comment from @anatbal)

@anatbal

anatbal commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

/test-destroy-env

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

Destroying PR test environment (RG: rg-tre85319da0)... (run: https://github.com/microsoft/AzureTRE/actions/runs/2781113370)

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

PR test environment destroy complete (RG: rg-tre85319da0)

@anatbal

anatbal commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

/test-extended

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2781258811 (with refid 85319da0)

(in response to this comment from @anatbal)

@anatbal

anatbal commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

/test-force-approve

Tests previously completed

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e334656)

(in response to this comment from @anatbal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airlock fields aren't ordered the same way in Swagger

4 participants