Renew Letsencrypt GitHub action is failing to access storage account

[jonnyry]

Checking in the Azure portal, the firewall on the storage account has been set to public.

»»» 🧩  Requesting LetsEncrypt SSL certificate...

╔══════════════════════════════════════╗
║          Azure TRE Makefile          ║
╚══════════════════════════════════════╝

»»» ✅ Checking pre-reqs...

Checking for Azure CLI...

Checking for Certbot...
/opt/az/azcliextensions/azure-devops/azext_devops/dev/__init__.py:5: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  import pkg_resources
[
  ***
    "cloudName": "AzureCloud",
    "homeTenantId": "XXX",
    "id": "XXX",
    "isDefault": true,
    "managedByTenants": [],
    "name": "SUBNAME",
    "state": "Enabled",
    ***,
    "user": ***
      "name": "XXX",
      "type": "servicePrincipal"
    ***
  ***
]
»»» 🔨 Azure details from logged on user 
»»»   • Subscription: SUBNAME
»»»   • Tenant:       XXX

/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/__init__.py:1: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  __import__('pkg_resources').declare_namespace(__name__)

Enabling public access on storage account ***
/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/__init__.py:1: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  __import__('pkg_resources').declare_namespace(__name__)
 Unable to confirm public access on storage account *** after 1/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 2/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 3/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 4/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 5/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 6/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 7/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 8/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 9/10. Waiting for update to take effect...
 Unable to confirm public access on storage account *** after 10/10. Waiting for update to take effect...
Error: Could not enable public access for *** after 10 attempts.

/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/__init__.py:1: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  __import__('pkg_resources').declare_namespace(__name__)
ERROR: The requested URI does not represent any resource on the server.
RequestId:acc0dfab-501e-00ec-4e28-e0d138000000
Time:2025-06-18T08:12:48.7111475Z
ErrorCode:InvalidUri

/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/__init__.py:1: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  __import__('pkg_resources').declare_namespace(__name__)

Disabling public access on storage account ***
/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/__init__.py:1: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  __import__('pkg_resources').declare_namespace(__name__)
 Public access has been disabled successfully

make: *** [Makefile:165: letsencrypt] Error 1
Error: Process completed with exit code 2.

[jonnyry]

Added some echo debugging statements into mgmtstorage_enable_public_access.sh and it looks like the warning message being outputted by az is spilling into the container name variable, causing is_public_access_enabled() to fail:

 Unable to confirm public access on storage account *** after 9/10. Waiting for update to take effect...

---------------------------------------------------------
az storage blob list --container-name "/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/__init__.py:1:" --account-name "***" --auth-mode login --output none
Container: /opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/__init__.py:1:
Tried listing blob output:
/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/__init__.py:1: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  __import__('pkg_resources').declare_namespace(__name__)
ERROR: The requested URI does not represent any resource on the server.
RequestId:d68c1754-f01e-00a8-4934-e05b07000000
Time:2025-06-18T09:34:57.2831706Z
ErrorCode:InvalidUri
---------------------------------------------------------

[jonnyry]

There's a bug in az where this warning is output to stdout rather than stderr:

Azure/azure-cli#31591

[marrobi]

@jonnyry hmm, is this not running in the dev container where the CLI is pinned?