Skip to content

Delaying retry on send when ConnectionException is thrown #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Delaying retry on send when ConnectionException is thrown #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../com/microsoft/applicationinsights/internal/channel/common/TransmissionNetworkOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.net.ConnectException;
import java.net.SocketException;
import java.net.UnknownHostException;
import java.text.DateFormat;
Expand Down Expand Up @@ -161,6 +162,10 @@ public boolean send(Transmission transmission) {
InternalLogger.INSTANCE.error("Failed to send, connection pool timeout exception");
} catch (SocketException e) {
InternalLogger.INSTANCE.error("Failed to send, socket timeout exception");
// backoff retry if no connection is found
if (e instanceof ConnectException) {
transmissionPolicyManager.suspendInSeconds(TransmissionPolicy.BLOCKED_BUT_CAN_BE_PERSISTED, DEFAULT_BACKOFF_TIME_SECONDS);
}
} catch (UnknownHostException e) {
InternalLogger.INSTANCE.error("Failed to send, wrong host address or cannot reach address due to network issues, exception: %s", e.getMessage());
} catch (IOException ioe) {
Expand Down