OtelTraceContextBuilder set parentId sampled as nullable as in TraceContext #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
reviewed
Dec 16, 2024
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Thank you for the fix. Let's add some tests for this so we don't have a regression around this in the future.
Contributor
|
fixed via 1831826 |
jonatan-ivanov
added
the
superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#911
in the TraceContext
parentId and sampled are nullable.
In the current OtelTraceContext if try to build a context without specify sampled u can an autoboxing NPE